Bug 9707 - configure fails when --with-sendfile-support option specified in Solaris
Summary: configure fails when --with-sendfile-support option specified in Solaris
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.9.4
Hardware: x86 Solaris
: P5 normal (vote)
Target Milestone: 4.10
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-10 01:38 UTC by KAMEI Yutaka (mail address dead)
Modified: 2019-05-29 15:13 UTC (History)
1 user (show)

See Also:

Attachments
Created patch for 3.6 (3.76 KB, patch)
2013-03-10 01:41 UTC, KAMEI Yutaka (mail address dead) 		no flags Details
Created patch for 3.5 (3.76 KB, patch)
2013-03-10 01:42 UTC, KAMEI Yutaka (mail address dead) 		no flags Details
Created patch for 4.0 (3.20 KB, patch)
2013-03-10 01:47 UTC, KAMEI Yutaka (mail address dead) 		no flags Details
Patch to also check for HAVE_SENDFILEV before failing the configuration step (1.26 KB, patch)
2019-05-29 13:50 UTC, Stefan Behrens 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KAMEI Yutaka (mail address dead) 2013-03-10 01:38:45 UTC 
I got following message.

...
checking for sendfilev in -lsendfile... yes
checking for solaris sendfilev64 support... yes
checking for solaris sendfilev support... yes
configure: error: sendfile support requested but sendfile not available
...

This message did not appear in Linux build environment.

In configure file, only $samba_cv_HAVE_SENDFILE is checked.
Following varialbes should be checked.

* $samba_cv_HAVE_SENDFILE
* $samba_cv_HAVE_SENDFILE64
* $samba_cv_HAVE_SENDFILEV
* $samba_cv_HAVE_SENDFILEV64
Comment 1 KAMEI Yutaka (mail address dead) 2013-03-10 01:41:44 UTC 
Created attachment 8624 [details]
Created patch for 3.6
Comment 2 KAMEI Yutaka (mail address dead) 2013-03-10 01:42:22 UTC 
Created attachment 8625 [details]
Created patch for 3.5
Comment 3 KAMEI Yutaka (mail address dead) 2013-03-10 01:47:16 UTC 
Created attachment 8626 [details]
Created patch for 4.0
Comment 4 Björn Jacke 2019-01-08 23:24:58 UTC 
fixed with

f23287bcb69d7c1318aad2472487066e6e6751f4
99c030bce6e246dfa1821a79abe751013b4bd2ef

in master
Comment 5 Stefan Behrens 2019-05-29 13:50:13 UTC 
Created attachment 15202 [details]
Patch to also check for HAVE_SENDFILEV before failing the configuration step

f23287bcb69d7c1318aad2472487066e6e6751f4 breaks the configuration process on Solaris.

You set HAVE_SENDFILEV for Solaris but check HAVE_SENDFILE (without the "V") and then fail with conf.fatal('sendfile support not found but it was requested !').

A patch is attached.
Comment 6 Stefan Behrens 2019-05-29 15:13:48 UTC 
And it also doesn't add a -lsendfile and fails the linking procedure with

$ make
[2431/3396] Linking bin/default/source4/dsdb/samdb/ldb_modules/test_unique_object_sids
[a long command line without any match to the term "sendfile"]
Undefined                       first referenced
 symbol                             in file
sendfilev64                         /...../samba/bin/default/source3/libsmbconf.so

$ nm /usr/lib/libsendfile.so | grep sendfilev
[46]    |      3081|        91|FUNC |LOCL |2    |15     |_sendfilev
[48]    |      2866|        91|FUNC |LOCL |2    |15     |_sendfilev64
[85]    |      3081|        91|FUNC |WEAK |0    |15     |sendfilev
[82]    |      2866|        91|FUNC |WEAK |0    |15     |sendfilev64

I think I better disable the sendfile thing for a while and instead investigate the "0x80000FFFF: Catastrophic failure" of Windows 10 when the user creates a new folder and somehow open("New folder", O_NOFOLLOW | O_RDWR) is called (and must fail with EISDIR) in non_widelink_open() after the mkdir() and the notifyd_trigger...