Bug 9418 - system md5.h is sometimes not correctly detected
system md5.h is sometimes not correctly detected
Product: Samba 3.6
Classification: Unclassified
Component: Build environment
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on: 9037 9086 9094
  Show dependency treegraph
Reported: 2012-11-21 19:19 UTC by Matthieu Patou
Modified: 2012-11-29 10:12 UTC (History)
2 users (show)

See Also:

Proposed patch for 3.6 (2.10 KB, patch)
2012-11-23 00:33 UTC, Matthieu Patou
vl: review+
metze: review+
Patch for v4-0-test (2.43 KB, patch)
2012-11-28 09:59 UTC, Stefan Metzmacher
mat: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-11-21 19:19:47 UTC
I have systems with md5.h installed in /usr/include (it's from cyrus-sasl packages) but just including this file is not enough to get the compilation ok.

The autoconf directive: AC_CHECK_HEADERS(md5.h) fails to correctly detect that including the system md5.h is not ok as it assumes that if a test involving just the C-preproc is enough even though the compiler failed to compile the same snipet.
Comment 1 Matthieu Patou 2012-11-21 19:21:59 UTC
This bug has been triggered by changes made in bug 9037 and the problems are similar to those in bug 9094.
Comment 2 Matthieu Patou 2012-11-21 19:43:35 UTC
Patch proposal from metze located at https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff_plain;h=3e6bd5e72e702ebe127008fb1037909f1c678fa4 fix the issue on 3.6.9.
Comment 3 Matthieu Patou 2012-11-23 00:33:36 UTC
Created attachment 8222 [details]
Proposed patch for 3.6
Comment 4 Matthieu Patou 2012-11-23 00:34:51 UTC
Tested on my platforms, it also integrate proposal from metze with fixes for missing test and inversed logic
Comment 5 Stefan Metzmacher 2012-11-23 07:16:19 UTC
Comment on attachment 8222 [details]
Proposed patch for 3.6

Looks good for 3.6
Comment 6 Matthieu Patou 2012-11-23 21:41:13 UTC
Volker and/or Bjorn can you check on *bsd ?
Comment 7 Stefan Metzmacher 2012-11-28 09:59:17 UTC
Created attachment 8234 [details]
Patch for v4-0-test
Comment 8 Matthieu Patou 2012-11-28 19:11:29 UTC

Can you take the 3.6 patch for the upcomming 3.6.10 and the 4.0 one for the v4-0-test branch ?

If more explanation are needed feel free to ping me.
Comment 9 Karolin Seeger 2012-11-29 08:05:36 UTC
Pushed to v3-6-test and autobuild-v4-0-test.
Comment 10 Karolin Seeger 2012-11-29 10:12:25 UTC
Pushed to v4-0-test.
Closing out bug report.