Bug 9303 - waf does not rebuild smb.conf.5 if documentation changed
Summary: waf does not rebuild smb.conf.5 if documentation changed
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.0.0rc3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Alexander Bokovoy
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 13:13 UTC by Björn Baumbach
Modified: 2017-07-16 22:21 UTC (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2012-10-18 13:13:05 UTC 
After changing a smb.conf option documentation waf does not rebuild the smb.conf.5 manual page.


Steps to reproduce:
-------------------
# make
WAF_MAKE=1 ./buildtools/bin/waf build
Waf: Entering directory `/home/bbaumba/src/git/samba/bin'
        Selected embedded Heimdal build
[ 126/3901] Generating VERSION
[ 161/3901] Generating smbd/build_options.c
Waf: Leaving directory `/home/bbaumba/src/git/samba/bin'
'build' finished successfully (7.178s)

# echo "alles weg" > docs-xml/smbdotconf/protocol/serverminprotocol.xml

# make
WAF_MAKE=1 ./buildtools/bin/waf build
Waf: Entering directory `/home/bbaumba/src/git/samba/bin'
        Selected embedded Heimdal build
[ 126/3901] Generating VERSION
[ 161/3901] Generating smbd/build_options.c
[ 168/3901] Generating smbdotconf/parameters.all.xml
Waf: Leaving directory `/home/bbaumba/src/git/samba/bin'
'build' finished successfully (7.241s)


Workaround:
-----------
# rm ./bin/default/docs-xml/smbdotconf/parameters.all.xml
# rm ./bin/default/docs-xml/manpages/smb.conf.5
Comment 1 Jelmer Vernooij 2012-10-19 06:57:56 UTC 
This is also affecting my branch to verify that all parameters are documented.
Comment 2 Stefan Metzmacher 2012-10-24 10:04:09 UTC 
This work in progress branch fixes the problem for me:
https://git.samba.org/mat/?p=mat/samba.git;a=shortlog;h=9b7b9bd62efa478e0
Comment 3 Björn Baumbach 2012-11-05 14:38:00 UTC 
Works for me t(In reply to comment #2)
> This work in progress branch fixes the problem for me:
> https://git.samba.org/mat/?p=mat/samba.git;a=shortlog;h=9b7b9bd62efa478e0

Works for me, too.
But it breaks the autobuild.
Comment 4 Alexander Bokovoy 2012-11-06 06:11:48 UTC 
 Björn, any specific details for the autobuild breakage?
Comment 5 Matthieu Patou 2012-11-06 06:44:58 UTC 
logs ?
Comment 6 Andrew Bartlett 2017-07-16 22:21:43 UTC 
This works in current master, and I think this was fixed by 2c86758b04515998c690f293fada2cc43116d764 in master for 4.2 and backported to 4.1.