Bug 9289 - Fix release script to build full set of documentation
Summary: Fix release script to build full set of documentation
Status: ASSIGNED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 4.0.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Alexander Bokovoy
QA Contact: Samba Documentation QA Contact~
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 07:04 UTC by Alexander Bokovoy
Modified: 2012-10-16 11:27 UTC (History)
1 user (show)

See Also:

Attachments
Fix release script to build full set of documentation (1.85 KB, patch)
2012-10-15 07:04 UTC, Alexander Bokovoy 		asn: review+
Details
Ensure Makefile in docs-xml always sets XML_CATALOG_FILES (default or user-supplied) (3.10 KB, patch)
2012-10-15 07:06 UTC, Alexander Bokovoy 		asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Bokovoy 2012-10-15 07:04:10 UTC 
build-docs script was not setting XML catalog properly.
    
In addition, some time ago pdf versions of images were introduced as generated dependencies in our books but svg -> pdf rule was not added, so building books never finished properly.

and 

Ensure XML_CATALOG_FILES set by default in the environment
that runs documentation build, both in docs-xml/Makefile build
and in waf build. This should fix problems people see in various
environments with docs-xml/Makefile build when not reading
docs-xml/build/README.

We now set XML_CATALOG_FILES to predefined set of /etc/xml/catalog and
our own local catalog (docs-xml/build/catalog.xml for Makefile build)
unless the variable is already defined in the environment where make
runs.
Comment 1 Alexander Bokovoy 2012-10-15 07:04:56 UTC 
Created attachment 8075 [details]
Fix release script to build full set of documentation
Comment 2 Alexander Bokovoy 2012-10-15 07:06:04 UTC 
Created attachment 8076 [details]
Ensure Makefile in docs-xml always sets XML_CATALOG_FILES (default or user-supplied)
Comment 3 Alexander Bokovoy 2012-10-15 07:06:53 UTC 
The second attachment is not yet on master (review in samba-technical@) but is necessary to ensure smb.conf.5 is built when using docs-xml/Makefile to build documentation.
Comment 4 Andreas Schneider 2012-10-15 08:55:45 UTC 
Comment on attachment 8075 [details]
Fix release script to build full set of documentation

lgtm
Comment 5 Andreas Schneider 2012-10-15 08:56:09 UTC 
Comment on attachment 8076 [details]
Ensure Makefile in docs-xml always sets XML_CATALOG_FILES (default or user-supplied)

lgtm
Comment 6 Karolin Seeger 2012-10-16 10:21:49 UTC 
Thanks a lot for providing the patch!
That fixes 'make manpages' without local rewrites for me! :-)

Pushed to autobuild-master.
Closing out bug report.

Thanks!
Comment 7 Karolin Seeger 2012-10-16 10:37:59 UTC 
Autobuild fails. Re-opening as a reminder.
Needs to be picked to v4-0-test also.
Comment 8 Karolin Seeger 2012-10-16 11:27:05 UTC 
Re-assigning to Alexander as the autobuild fails.