Bug 9157 - libpdb/pdb_ldap/idmap_ldap build dependencies cleanup
Summary: libpdb/pdb_ldap/idmap_ldap build dependencies cleanup
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 13:55 UTC by Alexander Bokovoy
Modified: 2021-02-11 14:00 UTC (History)
0 users

See Also:
asn: review+

Attachments
patch to move some pdb_ldap utility functions to smbldaphelper subsystem (3.40 KB, patch)
2012-09-13 13:56 UTC, Alexander Bokovoy 		asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Bokovoy 2012-09-13 13:55:48 UTC 
pdb_ldap is built out of few source files, with two of them also used in idmap_ldap. idmap_ldap expects them to be part of libpdb, by coincidence, because pdb_ldap is by default statically linked into libpdb.

If pdb_ldap is built as dynamic module, idmap_ldap module building is broken.

Attached patch fixes it. Please consider it to 4.0 stable.
Comment 1 Alexander Bokovoy 2012-09-13 13:56:52 UTC 
Created attachment 7889 [details]
patch to move some pdb_ldap utility functions to smbldaphelper subsystem
Comment 2 Alexander Bokovoy 2012-09-13 13:57:39 UTC 
Comment on attachment 7889 [details]
patch to move some pdb_ldap utility functions to smbldaphelper subsystem

Added Andreas as reviewer.
Comment 3 Alexander Bokovoy 2012-09-13 13:58:30 UTC 
Added flag in wrong place.
Comment 4 Andreas Schneider 2012-09-13 14:05:51 UTC 
Comment on attachment 7889 [details]
patch to move some pdb_ldap utility functions to smbldaphelper subsystem

lgtm and tested.
Comment 5 Alexander Bokovoy 2012-09-13 14:14:29 UTC 
Karolin, please include this patch into 4.0. It is currently on its way through autobuild to master
Comment 6 Karolin Seeger 2012-09-18 06:47:54 UTC 
Pushed to v4-0-test.
Closing out bug report.

Thanks!