Bug 9034 - Typo in set_re_uid() call when USE_SETRESUID selected in configure.
Summary: Typo in set_re_uid() call when USE_SETRESUID selected in configure.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 00:06 UTC by Jeremy Allison
Modified: 2012-09-24 04:22 UTC (History)
0 users

See Also:

Attachments
git am fix that applies to 3.6.next and 3.5.next. (991 bytes, patch)
2012-07-11 04:16 UTC, Jeremy Allison 		vl: review+
obnox: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2012-07-11 00:06:14 UTC 
We only set the real euid, not the effective one. This is not a security issue as this is *only* used in the quota code, and only between code that brackets it with save_re_uid()/restore_re_uid(), Also this is not used on most platforms (we use USE_SETREUID by preference) but it's better to have this right.

Patches for 3.6.next and 3.5.next to follow.

Jeremy.
Comment 1 Jeremy Allison 2012-07-11 04:16:55 UTC 
Created attachment 7694 [details]
git am fix that applies to 3.6.next and 3.5.next.
Comment 2 Jeremy Allison 2012-07-11 16:52:25 UTC 
Re-assigning to Karolin for inclusion in 3.5.next and 3.6.next.

Cheers,

Jeremy.
Comment 3 Karolin Seeger 2012-07-11 17:28:56 UTC 
Pushed to v3-6-test and v3-5-test.
Closing out bug report.

Thanks!