Found at an OEM. Ensure Samba is running with acl_xattr loaded. Using a Windows XP client with personal file sharing enabled (don't ask me why this needs to be so, it just does) - create a directory structure using notepad.exe as the following: \source\t1.txt \target Where \source and \target are directories. Then using explorer, "CUT" and paste (doesn't happen with COPY and paste) the \source directory into the \target directory. The operation will succeed, but whe accessing t1.txt by double clicking you will get "ACCESS DENIED". This is due to an ACL with zero ACE entries being applied to t1.txt. Patch to follow.
Note for the above. \source and \target need to be created from the Samba server, not by the client.
Created attachment 7155 [details] git-am fix for 3.6.x and 3.5.x. Fix I've applied to master (and confirms fixes the problem by the OEM). Applies to 3.6.x and 3.5.x. It's a pretty obvious fix once you look at it. Jeremy.
Ping. This really needs reviewing and adding to 3.6.next. It's also correct :-). Raising to blocker as I don't want to ship without this. Jeremy.
Is there a chance to get the review done during the next two days? Otherwise, we do need to delay 3.6.2 (which might happen anyway). Thanks!
(In reply to comment #4) > Is there a chance to get the review done during the next two days? > Otherwise, we do need to delay 3.6.2 (which might happen anyway). > > Thanks! What do you want by way of review? I have reviewed the code and the patch seems absolutely correct. However, I seem to be unable to mark it as reviewed.
Added Richard in the hope he can +1 this (obviously correct) fix. Jeremy.
I must be doing something wrong. I show two +1 reviews by me (realrichardsharpe) but it is not clear that it has shown elsewhere.
Comment on attachment 7155 [details] git-am fix for 3.6.x and 3.5.x. Looks good. Richard, there're also review flags on the attachment
Karolin, please pick for the next releases.
Pushed to v3-6-test and v3-5-test. Closing out bug report. Thanks!