Bug 8642 - VFS function names are inconsistent: Some end with _fn, some start with vfs_, most don't,
Summary: VFS function names are inconsistent: Some end with _fn, some start with vfs_,...
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 enhancement
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
Depends on:
Reported: 2011-12-02 15:38 UTC by Richard Sharpe
Modified: 2012-04-29 17:34 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Richard Sharpe 2011-12-02 15:38:56 UTC
I noticed that the naming of VFS functions in the structure that defines them is inconsistent. Eg:

        .open_fn = vfswrap_open,
        .create_file = vfswrap_create_file,
        .close_fn = vfswrap_close,
        .vfs_read = vfswrap_read,
        .pread = vfswrap_pread,
        .write = vfswrap_write,
        .pwrite = vfswrap_pwrite,

They should all probably be called <name>_fn, eg, create_file_fn, read_fn, pread_fn, write_fn, etc.

This will break out of tree modules, but the change is pretty mechanical.
Comment 1 Volker Lendecke 2011-12-02 15:44:04 UTC
For 3.6.2, I would not do this. For the next 3.x release, sure. If I was you, I would just post a patch somewhere and push it to master after some review. For 3.7 or 4.0 we don't have the bugzilla process.
Comment 2 Richard Sharpe 2012-04-29 17:34:55 UTC
This was fixed in change # 422494a8e630e2ca89386344eaa5346388698a32