Bug 8525 - Bug with sys_fseek() wrapper on *BSD / OS X.
Bug with sys_fseek() wrapper on *BSD / OS X.
Product: Samba 3.6
Classification: Unclassified
Component: Build environment
All OpenBSD
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2011-10-14 02:44 UTC by Brad Smith
Modified: 2011-10-20 18:01 UTC (History)
2 users (show)

See Also:

sys_fseek wrapper patch (558 bytes, text/plain)
2011-10-14 02:44 UTC, Brad Smith
no flags Details
sys_fseek wrapper patch (2.64 KB, patch)
2011-10-14 14:41 UTC, Brad Smith
no flags Details
v3-6-test.patch (3.12 KB, patch)
2011-10-17 09:19 UTC, Guenther Deschner
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Smith 2011-10-14 02:44:11 UTC
Created attachment 6998 [details]
sys_fseek wrapper patch

The sys_fseek() wrapper is currently using feek() instead of fseeko() as it is supposed to be for *BSD / OS X OS's when dealing with large files.
Comment 1 Volker Lendecke 2011-10-14 07:39:54 UTC
Comment on attachment 6998 [details]
sys_fseek wrapper patch

Thanks for pointing that out. It would be great if we could also get a configure check for fseeko.


Comment 2 Brad Smith 2011-10-14 14:41:14 UTC
Created attachment 7001 [details]
sys_fseek wrapper patch

Updated diff with autoconf test for fseeko.
Comment 3 Guenther Deschner 2011-10-14 14:52:30 UTC
Ok, pushing this change to master.
Comment 4 Guenther Deschner 2011-10-17 09:19:12 UTC
Created attachment 7004 [details]
Comment 5 Stefan Metzmacher 2011-10-17 09:24:56 UTC
Comment on attachment 7004 [details]

Looks, ok
Comment 6 Stefan Metzmacher 2011-10-17 09:25:50 UTC
Karalin, please pick for 3.6.1 or 3.6.2
Comment 7 Karolin Seeger 2011-10-17 18:23:57 UTC
Will pick it for 3.6.2 (branch is already frozen).
Comment 8 Karolin Seeger 2011-10-20 18:01:40 UTC
Pushed to v3-6-test.
Closing out bug report.