Bug 8401 - registry/reg_format.c must include includes.h
Summary: registry/reg_format.c must include includes.h
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.6.0
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 05:35 UTC by Todd Richmond
Modified: 2011-09-22 19:59 UTC (History)
0 users

See Also:

Attachments
patch from master (704 bytes, patch)
2011-08-25 14:03 UTC, Guenther Deschner 		bjacke: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Todd Richmond 2011-08-25 05:35:18 UTC 
While attempting to port samba 3.6 to OpenWRT, source3/registry/reg_format.c will not compile because includes.h is not included first as it is for other registry/*.c files. That prevents sys/stat.h from being included via config.h. The rest of samba compiles fine
Comment 1 Guenther Deschner 2011-08-25 14:03:25 UTC 
Created attachment 6805 [details]
patch from master
Comment 2 Guenther Deschner 2011-08-25 14:03:55 UTC 
Comment on attachment 6805 [details]
patch from master

This has been pushed to master...
Comment 3 Björn Jacke 2011-09-21 20:00:57 UTC 
karo: please pick this to 3.6, too
Comment 4 Karolin Seeger 2011-09-22 19:59:38 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!