Bug 8157 - std_pcap_cache_reload() fails to parse a cups printcap file correctly
Summary: std_pcap_cache_reload() fails to parse a cups printcap file correctly
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Printing (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 15:16 UTC by Guenther Deschner
Modified: 2011-05-23 18:45 UTC (History)
0 users

See Also:

Attachments
git-am fix for 3.5.next (1.44 KB, patch)
2011-05-20 19:39 UTC, Jeremy Allison 		gd: review+
Details
git-am fix for 3.6.0 (1.62 KB, patch)
2011-05-20 19:53 UTC, Jeremy Allison 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2011-05-20 15:16:56 UTC 
std_pcap_cache_reload() fails to parse a cups printcap file correctly
Comment 1 Jeremy Allison 2011-05-20 19:39:55 UTC 
Created attachment 6464 [details]
git-am fix for 3.5.next

Fix for 3.5.x - fix for 3.6.0 will follow.
Jeremy.
Comment 2 Jeremy Allison 2011-05-20 19:53:18 UTC 
Created attachment 6465 [details]
git-am fix for 3.6.0

Need to be applied to 3.6.0 also.

Jeremy.
Comment 3 Guenther Deschner 2011-05-20 20:01:27 UTC 
Comment on attachment 6464 [details]
git-am fix for 3.5.next

looks good
Comment 4 Guenther Deschner 2011-05-20 20:01:50 UTC 
Comment on attachment 6465 [details]
git-am fix for 3.6.0

looks good
Comment 5 Guenther Deschner 2011-05-20 20:02:59 UTC 
tested the fix and it resolves the issue of flipped printername/printercomment in printcap parsing, thanks Jeremy!

Karolin, please add to 3.5 and 3.6
Comment 6 Karolin Seeger 2011-05-23 18:45:48 UTC 
Pushed to both branches.
Closing out bug report.

Thanks!