Bug 8036 - rsync should refuse -B values larger than the maximum block size
Summary: rsync should refuse -B values larger than the maximum block size
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 14:47 UTC by Numérigraphe SARL
Modified: 2011-12-24 20:19 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Numérigraphe SARL 2011-03-23 14:47:04 UTC 
The maximum value for -B does not seem to be enforced when parsing the command-line options: it will happily start working with larger values, often to fail with a protocol error after some blocks are transfered.
The maximum value (2^17 if I'm not mistaken) should be enforced and reported to the user, all the more as it is mostly undocumented.
Lionel Sausin.
Comment 1 Wayne Davison 2011-12-24 20:19:57 UTC 
I'm checking in a fix for this.