Bug 7111 - --fake-super should set real file u+x if source is executable
Summary: --fake-super should set real file u+x if source is executable
Status: ASSIGNED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: All All
: P3 minor (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-07 19:48 UTC by Matt McCutchen
Modified: 2011-01-01 20:08 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2010-02-07 19:48:21 UTC 
The --fake-super mode should set u+x on the real file if the source file is executable.  This would be consistent with Linux permission checking for the real superuser:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=fs/namei.c;hb=6339204ecc2aa2067a99595522de0403f0854bb8#l226

Test case (run as non-root):
touch file
chmod 401 file
rsync-dev -a -M--fake-super file file2
if [ -x file2 ]; then echo "PASS"; else echo "FAIL"; fi