Bug 7052 - DFS broken on AIX (maybe others) due to readlink() differences.
DFS broken on AIX (maybe others) due to readlink() differences.
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: Build environment
3.4.4
PPC AIX
: P3 major
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-21 06:52 UTC by William Jojo
Modified: 2010-01-22 04:24 UTC (History)
1 user (show)

See Also:
obnox: review+


Attachments
Patch to (more) correctly identify broken readlink() (244 bytes, patch)
2010-01-21 06:55 UTC, William Jojo
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Jojo 2010-01-21 06:52:01 UTC
The readlink() call on AIX can return ERANGE which is currently not handled.

This patch fixes an invalid test of readlink() which is not correctly identifying broken readlink() calls.
Comment 1 William Jojo 2010-01-21 06:55:35 UTC
Created attachment 5213 [details]
Patch to (more) correctly identify broken readlink()
Comment 2 Volker Lendecke 2010-01-21 07:16:29 UTC
Nice :-))

Volker
Comment 3 Volker Lendecke 2010-01-21 07:23:34 UTC
Pushed to master, thanks. I think this needs to go into 3.3 and 3.4 as well. Ack from my side.

Volker
Comment 4 Jeremy Allison 2010-01-21 14:44:51 UTC
Oh, that's elegant ! Re-assigning to Karolin for inclusion in 3.5.0, 3.4.6 and 3.3.11.
Jeremy.
Comment 5 Karolin Seeger 2010-01-22 03:09:18 UTC
Pushed to all branches.
Closing out bug report.

Thanks!
Comment 6 Michael Adam 2010-01-22 04:24:41 UTC
Too late as always .... sorry :-}