Build with aio support fails on Debian Sarge with: sarge-i386[chroot]:~/build/samba/samba-3.5.0pre1/source3#./autogen.sh && ./configure --with-aio-support && make [...] creating /root/build/samba/samba-3.5.0pre1/source3/exports/libnetapi.syms Linking shared library bin/libnetapi.so.0 lib/pthreadpool.o(.text+0x1ae): In function `pthreadpool_join_children': : undefined reference to `pthread_join' lib/pthreadpool.o(.text+0x685): In function `pthreadpool_add_job': : undefined reference to `pthread_sigmask' lib/pthreadpool.o(.text+0x6bd): In function `pthreadpool_add_job': : undefined reference to `pthread_create' lib/pthreadpool.o(.text+0x6e7): In function `pthreadpool_add_job': : undefined reference to `pthread_sigmask' collect2: ld returned 1 exit status make: *** [bin/libnetapi.so.0] Error
Created attachment 5076 [details] config.log.gz
Created attachment 5077 [details] Output of ./autogen.sh && ./configure --with-aio-support && make
Works fine on Debian Etch (i386) and OpenSUSE 11.2 (i386).
Björn, 5439e1a0 fixes the issue on my box :-)
great, can you please pick those patches to 3.5: 5439e1a03f66f squash 6bade10a1eb216896 squash 1f7e97a8a257b3280 118725c892e445fcc
wait a moment, the disabling of the default of pthread pool support leads to some build problem. Another fix will be needed ...
Björn, what's the status here? I have a review flag open for this, but the last comment says "build problem -- further patch needed". Thanks, Volker
a20b43f23f2254edb1fcd6d3916dd57e6a4778ee is another patch in the series but I want to wait for the Tru64 build bachine to re-appear in the buildfarm and watch that before giving the "go" here.
latest patch set to fix pthread build: 5439e1a03f66f squash 6bade10a1eb216896 squash 1f7e97a8a257b3280 squash a20b43f23f2254edb squash acedd1c8320afa672 squash 55d65ba7213e5b307 118725c892e445fcc Karolin, does that still completely build on the mentioned Debian system? If yes, Volker should finally review the patch set for merging to 3.5.
(In reply to comment #9) > latest patch set to fix pthread build: > > 5439e1a03f66f > squash 6bade10a1eb216896 > squash 1f7e97a8a257b3280 > squash a20b43f23f2254edb > squash acedd1c8320afa672 > squash 55d65ba7213e5b307 > 118725c892e445fcc > > Karolin, does that still completely build on the mentioned Debian system? If > yes, Volker should finally review the patch set for merging to 3.5. > Yes, the build completed successfully. :-) Volker, is there a chance to review the patches?
Can we get this as a patchset that is complete? Thanks, Volker
Don't have time right now, I'll review them later. Volker
I really think fixing all the Unix builds is worth a goal for 3.5 when we have the patches already, adding myself for review.
Günther, if you get this reviewed done today I'll go only for you into the office to get the remote control :-).
Patchset looks fine to me.
Pushed to v3-5-test. Closing out bug report. Thanks!