Bug 6804 - Fix severe HP-UX PA-Risc Compiler issue, cosmetic for others
Fix severe HP-UX PA-Risc Compiler issue, cosmetic for others
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: File services
3.4.2
Other HP-UX
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-13 04:48 UTC by Olaf Flebbe
Modified: 2009-10-13 11:44 UTC (History)
0 users

See Also:


Attachments
Explicitly initialize enum_list member of struct to zero (934 bytes, patch)
2009-10-13 04:49 UTC, Olaf Flebbe
no flags Details
Essentially the same patch relative to master (1.20 KB, text/x-patch)
2009-10-13 07:15 UTC, Olaf Flebbe
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Flebbe 2009-10-13 04:48:02 UTC
Hi,

param/loadparm.c triggers a severe compiler HP-UX PA-Risc issue in the latest compiler: All binaries get ridiculous large for instance smbd is 300 MB.

It is a problem with non initializing all the struct entries  of parm_table.

AFAIK it is not neccesary to initialize all struct elements explicitly according to ANSI C, but it does not harm to do it and helps the compiler tremendously. Please apply in 3.4.x and upstream.
Comment 1 Olaf Flebbe 2009-10-13 04:49:23 UTC
Created attachment 4831 [details]
Explicitly initialize enum_list member of struct to zero
Comment 2 Volker Lendecke 2009-10-13 05:42:41 UTC
Looks good to me. We've just also added the ldap referral parameter, I think this suffers from the same problem.

Volker
Comment 3 Olaf Flebbe 2009-10-13 07:05:49 UTC
(In reply to comment #2)
> Looks good to me. We've just also added the ldap referral parameter, I think
> this suffers from the same problem.

You're talking abaout the ldap ref follow parameter in "master"?

Indeed the .special is missing there. 

But this parameter isn't available in 3.4.x

I was in the impression I should submit patches for 3.4.x not master.
Comment 4 Volker Lendecke 2009-10-13 07:07:25 UTC
Sure, but you do not want to hit this exact problem in a years time again :-)

Volker
Comment 5 Olaf Flebbe 2009-10-13 07:15:13 UTC
Created attachment 4832 [details]
Essentially the same patch relative to master
Comment 6 Karolin Seeger 2009-10-13 09:39:27 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Looks good to me. We've just also added the ldap referral parameter, I think
> > this suffers from the same problem.
> 
> You're talking abaout the ldap ref follow parameter in "master"?
> 
> Indeed the .special is missing there. 
> 
> But this parameter isn't available in 3.4.x
> 
> I was in the impression I should submit patches for 3.4.x not master.
> 

Comment 7 Karolin Seeger 2009-10-13 11:44:20 UTC
Oops, last comment was added by accident, sorry!

Pushed patches to master, v3-5-test and v3-4-test.
Closing out bug report.

Thanks for providing the patch!