Bug 6719 - I/O error protection is broken w/ protocol 30 and incremental recursion
Summary: I/O error protection is broken w/ protocol 30 and incremental recursion
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.0.7
Hardware: All All
: P3 critical (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2009-09-13 16:16 UTC by Matt McCutchen
Modified: 2009-12-31 15:49 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2009-09-13 16:16:08 UTC
See http://lists.samba.org/archive/rsync/2009-September/023892.html .  IIUC, the feature that disables deletion upon an I/O error is mostly non-functional with protocol 30, incremental recursion, and --delete-during.  That could lead to a catastrophic loss of destination files, which the feature was intended to prevent.

One safe behavior for a sender that gets an I/O error and is unable to report it reliably to the receiving side would be to exit immediately with a message explaining the issue.  That way, users with rsync 3.0.* (the current stable branch) can still use incremental recursion safely and then switch to a different approach if they frequently get I/O errors.
Comment 1 Wayne Davison 2009-12-31 15:49:26 UTC
3.0.7 has this fixed (and in a way that is compatible with 3.1.0).  If the sender has enough information to know that it should die when an I/O happens (for an older receiver that is doing a delete-during pass), it will do that too.