Bug 6353 - renaming users in usrmgr requires rename script for ldapsam:editposix=yes
Summary: renaming users in usrmgr requires rename script for ldapsam:editposix=yes
Status: ASSIGNED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: User & Group Accounts (show other bugs)
Version: unspecified
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Gregor Beck (550 Unknown user)
QA Contact: Samba QA Contact
URL:
Keywords:
: 4335 6587 7895 (view as bug list)
Depends on:
Blocks: 4335
  Show dependency tree / graph
 
Reported: 2009-05-12 14:43 UTC by Guenther Deschner
Modified: 2011-01-14 01:43 UTC (History)
5 users (show)

See Also:
gd: review+
vl: review+
bjacke: review-

Attachments
rename users w/o scripts for ldapsam:editposix=yes (5.32 KB, patch)
2009-05-12 14:44 UTC, Guenther Deschner 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2009-05-12 14:43:28 UTC 
renaming users in usrmgr requires rename script for ldapsam:editposix=yes which it shouldn't in that case
Comment 1 Guenther Deschner 2009-05-12 14:44:47 UTC 
Created attachment 4146 [details]
rename users w/o scripts for ldapsam:editposix=yes

This does not handle changes in group membership though.
Comment 2 Simo Sorce 2009-05-14 07:16:13 UTC 
Ack, looks correct.
Thanks for catching this one.
Comment 3 Björn Jacke 2009-05-14 14:41:42 UTC 
*** Bug 4335 has been marked as a duplicate of this bug. ***
Comment 4 Volker Lendecke 2009-05-15 13:40:23 UTC 
Looks correct. Just one little stylistic remark: We have the routine talloc_autofree_ldapmsg which might help here.

Volker
Comment 5 Björn Jacke 2009-05-17 14:12:25 UTC 
I think the handling of group memberships really should be added before. Hyena allows renaming of user accounts and if group memberships are lost this is a bad thing.

It's even a security risk if later on a new account is created who has the same name as the old (renamed) account and if the group memberships are not checked by the account creation tool. The new user then has the old group memberships of the other renamed user.
Comment 6 Guenther Deschner 2009-06-05 06:18:35 UTC 
Simo agreed on patch.
Comment 7 Karolin Seeger 2009-06-30 04:38:35 UTC 
What about this one?
Should we pick that for 3.4.0?
Comment 8 David Markey 2009-08-14 04:39:29 UTC 
*** Bug 6587 has been marked as a duplicate of this bug. ***
Comment 9 Stefan Metzmacher 2011-01-04 04:38:05 UTC 
*** Bug 7895 has been marked as a duplicate of this bug. ***
Comment 10 Björn Jacke 2011-01-04 04:49:56 UTC 
Gregor is working on a fix that includes the group membership handling.
Comment 11 Stefan Metzmacher 2011-01-04 08:27:47 UTC 
This might also be useful

http://gitweb.samba.org/?p=gd/samba/.git;a=shortlog;h=refs/heads/master-editposix