Bug 6338 - net rpc trustdom list always display "none"
net rpc trustdom list always display "none"
Status: NEW
Product: Samba 3.4
Classification: Unclassified
Component: Domain Control
3.4.0
x86 Linux
: P3 trivial
: ---
Assigned To: Volker Lendecke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-08 02:15 UTC by TAKAHASHI Motonobu
Modified: 2010-05-26 08:02 UTC (History)
1 user (show)

See Also:


Attachments
Patch for 3.3 (2.77 KB, patch)
2009-11-22 15:50 UTC, Volker Lendecke
obnox: review+
Details
Patch for 3.4 (2.77 KB, patch)
2009-11-22 15:58 UTC, Volker Lendecke
obnox: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TAKAHASHI Motonobu 2009-05-08 02:15:03 UTC
net rpc trustdom list always display "none" even if some trusted domain exists:

-----
# /usr/local/samba/bin/net rpc trustdom  list  -U ""%""
Trusted domains list:

W2K8AD1             S-1-5-21-1234995458-293493368-1744720997
none
-----
Comment 1 Volker Lendecke 2009-11-22 15:50:03 UTC
Created attachment 4976 [details]
Patch for 3.3

Attached find a patch for 3.3
Comment 2 Volker Lendecke 2009-11-22 15:58:38 UTC
Created attachment 4977 [details]
Patch for 3.4

And a patch for 3.4.

Thanks for reporting this!

Volker
Comment 3 Michael Adam 2009-11-24 08:54:56 UTC
Comment on attachment 4976 [details]
Patch for 3.3

Looks good.

Actually there must be somthething wrong in the  the return of the EnumTrustDom call from the samba pdc, but this patch is good anyways.
Comment 4 Michael Adam 2009-11-24 08:55:08 UTC
Comment on attachment 4977 [details]
Patch for 3.4

Looks good.

Actually there must be somthething wrong in the  the return of the EnumTrustDom call from the samba pdc, but this patch is good anyways.
Comment 5 Karolin Seeger 2009-11-24 09:09:02 UTC
Pushed patches to v3-3-test and v3-4-test.
Comment 6 Karolin Seeger 2009-11-24 09:10:08 UTC
(In reply to comment #4)
> (From update of attachment 4977 [details])
> Looks good.
> 
> Actually there must be somthething wrong in the  the return of the EnumTrustDom
> call from the samba pdc, but this patch is good anyways.
> 

Can we close the bug report?
Comment 7 Guenther Deschner 2009-11-24 09:23:11 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 4977 [details] [details])
> > Looks good.
> > 
> > Actually there must be somthething wrong in the  the return of the EnumTrustDom
> > call from the samba pdc, but this patch is good anyways.

Just in case Michael saw queries with NT_STATUS_OK but no returned domains, these two fixes might resolve that:
49a13234957ad241e6457bbf0edc15875321f03f and 209a65bc6f783055f3f6a8cea3fb36587d346511
Comment 8 Volker Lendecke 2009-11-24 12:11:29 UTC
Yes, that's what had happened.

Volker
Comment 9 Karolin Seeger 2009-11-25 03:06:36 UTC
(In reply to comment #8)
> Yes, that's what had happened.
> 
> Volker
> 

Volker, can you confirm that I shall pick 49a13234957ad241e6457bbf0edc15875321f03f and
209a65bc6f783055f3f6a8cea3fb36587d346511 for v3-3-test and v3-4-test, please?

Thanks!
Comment 10 Volker Lendecke 2009-11-25 03:27:16 UTC
They look right, but I do not have time to test them right now. If you provide the environment and show me sniffs with and without, I can take a look and ack them quickly.

Volker
Comment 11 Karolin Seeger 2010-05-26 08:02:38 UTC
Updating component as 3.3 is in the security fixes only mode.