Bug 5008 - make check fails on Cygwin (default-acls)
Summary: make check fails on Cygwin (default-acls)
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.0.0
Hardware: x86 Other
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2007-10-05 03:19 UTC by Denis Excoffier
Modified: 2020-07-26 01:27 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Denis Excoffier 2007-10-05 03:19:26 UTC
On cygwin, using only the additional "--wish-rsh=rsh" parameter to ./configure, "make check" passes all the tests (some are skipped) except for "default-acls". This is a copy of test.log:

Testing for symlinks using 'test -h'
sending incremental file list
created directory /tmp/local/unixutil/.tmp/rsync/rsync-3.0.0pre1/testtmp/default-acls/da777/to
delta-transmission disabled for local transfer or --whole-file
total: matches=0  hash_hits=0  false_alarms=0 data=16

sent 168 bytes  received 53 bytes  147.33 bytes/sec
total size is 16  speedup is 0.07
permissions: rwx------ on /tmp/local/unixutil/.tmp/rsync/rsync-3.0.0pre1/testtmp/default-acls/da777/to
should be:   rwxrwxrwx
failed test Target da777

The complete build is OK under Solaris 2.8.
Comment 1 Denis Excoffier 2007-10-12 04:57:13 UTC
The original report was against 3.0.0pre1.

The same behaviour also occurs with 3.0.0pre2.
Comment 2 Wayne Davison 2007-10-12 10:10:57 UTC
I don't have access to an MS Win box to test this, but I imagine that that this is just showing that MS ACLs work differently.
Comment 3 Denis Excoffier 2007-10-12 10:56:55 UTC
Waiting for more information on this, i suggest that you "SKIP" the test in the Cygwin case.
Comment 4 Wayne Davison 2020-07-26 01:27:15 UTC
This test has been made to auto-skip in the latest git source (and a couple other fixes and improvements made for Cygwin, including getting xattrs supported). The Cygwin CI builds are doing well on GitHub Actions.

The details behind this particular failure are that the test expects to be able to turn off all default-ACL mode changes by disabling the default-ACLs on one parent directory. However, under Cygwin new directories withing that parent directory still get created with a default-ACL rule that causes the mode of new files to not be what the test expects.  Thus, just skipping that test seems to be the best solution.