Bug 4995 - source_filter dest_filter patch fails in 2.6.9
Summary: source_filter dest_filter patch fails in 2.6.9
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.9
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-26 04:34 UTC by NIck Blundell
Modified: 2007-09-26 10:26 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NIck Blundell 2007-09-26 04:34:43 UTC 
When rsync 2.6.9 is patched with the patch: rsync-2.6.9/patches/source-filter_dest-filter.diff

You get this:

rsync: read errors mapping "<some file>": No data available (61)

By re-ordering some code in the patch, this can be made to function correctly. I have a patch here to fix this: http://projects.nickblundell.org.uk/sites/projects.nickblundell.org.uk/files/blundell_rsync2.6.9_source_dest_filter.patch
Comment 1 Wayne Davison 2007-09-26 10:26:32 UTC 
I have made the analogous change to the patch in CVS.

Thanks for your help.

A note for future patches:

An easier way to show what changed in a patch is to produce a diff that can be applied to the code after the released diff.  E.g. patch your rsync-2.6.9-orig code with the patch before you diff against the fixed code.  FYI.