Bug 4636 - Warnings in nsswitch/pam_winbind.c
Warnings in nsswitch/pam_winbind.c
Status: NEW
Product: Samba 3.0
Classification: Unclassified
Component: winbind
Other FreeBSD
: P3 normal
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2007-05-17 16:44 UTC by Mikhail T.
Modified: 2007-05-17 16:46 UTC (History)
0 users

See Also:

silence the warnings on FreeBSD/amd64 (5.61 KB, patch)
2007-05-17 16:46 UTC, Mikhail T.
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2007-05-17 16:44:44 UTC
The numerous warnings are of two groups:
1. Overly aggressive const-ness -- the pointer to pam_handle_t* is never const, for example, and pam_get_data's last argument should not be const either.
2. Casting pointers into 32-bit integers for printing -- a problem on 64-bit systems.

The patch I'm about to attach closes all of these warnings by removing const, where needed, and by printing pointers using %p instead of the dubious casting. Please, review.
Comment 1 Mikhail T. 2007-05-17 16:46:11 UTC
Created attachment 2703 [details]
silence the warnings on FreeBSD/amd64