Bug 4636 - Warnings in nsswitch/pam_winbind.c
Summary: Warnings in nsswitch/pam_winbind.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: winbind (show other bugs)
Version: 3.0.25
Hardware: Other FreeBSD
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-17 16:44 UTC by Mikhail T.
Modified: 2016-12-16 10:12 UTC (History)
0 users

See Also:

Attachments
silence the warnings on FreeBSD/amd64 (5.61 KB, patch)
2007-05-17 16:46 UTC, Mikhail T. 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2007-05-17 16:44:44 UTC 
The numerous warnings are of two groups:
1. Overly aggressive const-ness -- the pointer to pam_handle_t* is never const, for example, and pam_get_data's last argument should not be const either.
2. Casting pointers into 32-bit integers for printing -- a problem on 64-bit systems.

The patch I'm about to attach closes all of these warnings by removing const, where needed, and by printing pointers using %p instead of the dubious casting. Please, review.
Comment 1 Mikhail T. 2007-05-17 16:46:11 UTC 
Created attachment 2703 [details]
silence the warnings on FreeBSD/amd64
Comment 2 Björn Jacke 2016-12-16 10:12:19 UTC 
sorry, for the long delay, those seem to be fixed already.