Bug 3894 - utils/eventlogadm.c: "pret" is set but never used
Summary: utils/eventlogadm.c: "pret" is set but never used
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.23
Hardware: Other Other
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 14:29 UTC by Jason Mader (mail bounces back)
Modified: 2006-06-28 16:56 UTC (History)
0 users

See Also:

Attachments
Change the use of pret (600 bytes, patch)
2006-06-28 15:21 UTC, Jason Mader (mail bounces back) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2006-06-28 14:29:54 UTC 
--- utils/eventlogadm.o ---
cc-1552 c99: WARNING File = utils/eventlogadm.c, Line = 92
  The variable "pret" is set but never used.

        int pret, rcnum;
            ^
Comment 1 Jason Mader (mail bounces back) 2006-06-28 15:16:24 UTC 
If "pret" is going to be used, it should be type BOOL to match parse_logentry( ).

Also notice the conditional just past this parse function,

if ( is_eor ) {
}

maybe the pret should be used in that too?

if ( is_eor && pret )
Comment 2 Jason Mader (mail bounces back) 2006-06-28 15:21:47 UTC 
Created attachment 1995 [details]
Change the use of pret
Comment 3 Jeremy Allison 2006-06-28 16:56:09 UTC 
Fixed thanks !
Jeremy.