Bug 3451 - client/umount.cifs.c needlessly includes fstab.h
client/umount.cifs.c needlessly includes fstab.h
Status: RESOLVED FIXED
Product: CifsVFS
Classification: Unclassified
Component: user space tools
2.6
Other Linux
: P3 normal
: ---
Assigned To: Steve French
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-25 22:33 UTC by Mike Frysinger
Modified: 2006-02-24 00:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Frysinger 2006-01-25 22:33:43 UTC
during a sync of codebases, the umount.cifs.c file started including the fstab.h header file ... uClibc for example does not provide this header file

looking at the change:
http://websvn.samba.org/cgi-bin/viewcvs.cgi/trunk/source/client/umount.cifs.c?rev=7141&r1=6422&r2=7141

i dont see any code which actually requires definitions/prototypes found in fstab.h ... so can it please be simply cut out ?
Comment 1 Steve French 2006-01-26 13:12:24 UTC
I don't see anything either (at least in current fstab.h) which would require the header to be included, at least not anymore, setmntent does not require it
Comment 2 Steve French 2006-02-24 00:10:40 UTC
done (at least for trunk)