Bug 2675 - --backup --suffix=.foo --delete-after doesn't backup deleted files
Summary: --backup --suffix=.foo --delete-after doesn't backup deleted files
Status: CLOSED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 2.6.4
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL: http://bugs.debian.org/cgi-bin/bugrep...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-02 04:12 UTC by Paul Slootman
Modified: 2005-06-03 01:39 UTC (History)
0 users

See Also:

Attachments
Fix the combination of --backup with --delete-after (612 bytes, patch)
2005-05-02 09:37 UTC, Wayne Davison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Slootman 2005-05-02 04:12:58 UTC 
I had a report from a debian user that his rsync job stopped leaving deleted
files behind (with the suffix appended) when he upgraded from 2.6.3. (See URL
for his full message). I've confirmed this.

Additionally, I discovered that when also using --delete-after, the backup
suffix needs to be --exclude-ed, otherwise the backup is deleted after being
created, during the same run...
Comment 1 Wayne Davison 2005-05-02 09:36:36 UTC 
It helps to look at the NEWS file from CVS so that you won't duplicate bugs that
have already been fixed (this is mentioned in the checklist on the bug-reporting
page, complete with a link to the unpacked NEWS file).

As for excluding the backup suffix when using --delete-after, that has always
been required -- I've considered adding an automatic exclude for it, but have
left it compatible with older versions for the time being.
Comment 2 Wayne Davison 2005-05-02 09:37:32 UTC 
Created attachment 1202 [details]
Fix the combination of --backup with --delete-after