Bug 2443 - Samba does not compile with GCC4 snapshot
Samba does not compile with GCC4 snapshot
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.11
All Linux
: P3 normal
: none
Assigned To: Tim Potter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-14 00:00 UTC by Mark Loeser
Modified: 2005-08-24 10:26 UTC (History)
0 users

See Also:


Attachments
GCC4 compile fix (485 bytes, patch)
2005-03-14 00:01 UTC, Mark Loeser
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Loeser 2005-03-14 00:00:36 UTC
GCC4 does not compile the latest Samba release because an array is being made
with an incomplete type.

Compiling lib/version.c
Compiling client/smbmnt.c
Compiling lib/snprintf.c
In file included from include/smb.h:1679,
                 from include/includes.h:819,
                 from lib/version.c:22:
include/popt_common.h:25: error: array type has incomplete element type
include/popt_common.h:26: error: array type has incomplete element type
include/popt_common.h:27: error: array type has incomplete element type
include/popt_common.h:28: error: array type has incomplete element type
In file included from include/smb.h:1679,
                 from include/includes.h:819,
                 from client/smbmnt.c:9:
include/popt_common.h:25: error: array type has incomplete element type
include/popt_common.h:26: error: array type has incomplete element type
include/popt_common.h:27: error: array type has incomplete element type
include/popt_common.h:28: error: array type has incomplete element type
make: *** [lib/version.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [client/smbmnt.o] Error 1 

The simplest solution is to make it a defined type by adding the include. 
Attached is a patch.
Comment 1 Mark Loeser 2005-03-14 00:01:00 UTC
Created attachment 1029 [details]
GCC4 compile fix
Comment 2 Gerald (Jerry) Carter 2005-03-14 07:39:56 UTC
fixed by tpot.
Comment 3 Gerald (Jerry) Carter 2005-08-24 10:26:31 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.