Bug 1964 - Compilation fail on NetBSD, when --with-quotas is specified..
Summary: Compilation fail on NetBSD, when --with-quotas is specified..
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.7
Hardware: All NetBSD
: P3 normal
Target Milestone: none
Assignee: Björn Jacke
QA Contact: Samba QA Contact
Depends on:
Reported: 2004-10-23 10:25 UTC by Andrej Misovic (mail address dead)
Modified: 2019-06-14 08:43 UTC (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Misovic (mail address dead) 2004-10-23 10:25:39 UTC
Compilation fail on NetBSD, when --with-quotas is specified..

..problem is, that file smbd/quotas.c don't mention about nbsd in any definition,
and compilation failed on line 932, where is condition:

#else /* !__FreeBSD__ && !AIX && !__OpenBSD__ */
#include <sys/quota.h>
#include <devnm.h>
..this is of course in linux case only..

I soluted this just only with adding this to begining of file:

#define __OpenBSD__

..and everything works fine..
it's a bit stupid solution, I think, in places, where OpenBSD is mentioned
should be NetBSD added too..
Comment 1 Björn Jacke 2014-11-06 12:57:31 UTC
I think this is not a problem anymore at least since the sysquota code was extended some years ago. Luke, can you confirm that NetBSD quotas compile find with 4.x ?
Comment 2 Björn Jacke 2019-02-12 23:50:55 UTC
NetBSD has two quota interface implementations - a (deprecated) syscall based one and a library base one. I can find not a single project which supports any of the NetBSD quota implementations. Neither we. I'm afraid also nobody misses them in Samba?
Comment 3 Andrew Bartlett 2019-06-14 08:43:04 UTC
(In reply to Björn Jacke from comment #2)
Given both your comments, I don't think it is reasonable to keep this bug open.

Closing as most likely fixed, it can be re-opened if someone has a need and active ability to reproduce.