Bug 16253 - smbstatus byte-range locks broken by Persistent Handle changes
Summary: smbstatus byte-range locks broken by Persistent Handle changes
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.25.0rc*
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba release manager
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-09-21 10:53 UTC by Ralph Böhme
Modified: 2026-09-24 21:59 UTC (History)
2 users (show)

See Also:


Attachments
Patch for 4.25 cherry-picked from master (4.17 KB, patch)
2026-09-21 14:00 UTC, Ralph Böhme
slow: review? (bjacke)
vl: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2026-09-21 10:53:15 UTC
brl_traverse_fn() walked the record itself instead of going through brl_parse_data(), which is broken soince the Persistent Handle patchset put a four byte version prefix in front of the lock array.

Have patch, need bugnumber...
Comment 1 Samba QA Contact 2026-09-21 13:24:03 UTC
This bug was referenced in samba master:

8070be375433503407e1bc07bdd2b89e36a9a66f
Comment 2 Ralph Böhme 2026-09-21 14:00:49 UTC
Created attachment 19235 [details]
Patch for 4.25 cherry-picked from master
Comment 3 Samba QA Contact 2026-09-24 21:28:03 UTC
This bug was referenced in samba v4-25-test:

db2936c7c054836739b6a5dba92b256070c1dae4
Comment 4 Samba QA Contact 2026-09-24 21:59:33 UTC
This bug was referenced in samba v4-25-stable (Release samba-4.25.0):

db2936c7c054836739b6a5dba92b256070c1dae4