Bug 16252 - samba.tests.krb5.pkinit_tests flaky
Summary: samba.tests.krb5.pkinit_tests flaky
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Python (show other bugs)
Version: 4.25.0rc*
Hardware: All All
: P5 regression (vote)
Target Milestone: 4.25
Assignee: Douglas Bagnall
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-09-19 09:50 UTC by Björn Jacke
Modified: 2026-09-22 15:50 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2026-09-19 09:50:29 UTC
multiple times already this test breaks the 4.25 tree build, delaying the 4.25 release:

Can someone please have a look what is wrong with that test or if this points to a samba bug? If this is a test bug and the test can't be fixed, please mark it flaky.

[327(7057)/338 at 1h3m29s] samba.tests.krb5.pkinit_tests(ad_dc)
UNEXPECTED(failure): samba.tests.krb5.pkinit_tests.samba.tests.krb5.pkinit_tests.PkInitTests.test_pkinit_smartcard_required_must_change_short_tgt(ad_dc)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/pkinit_tests.py", line 1268, in test_pkinit_smartcard_required_must_change_short_tgt
    return self._test_pkinit_smartcard_required_must_change(short_tgt_lifetime=True)
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/pkinit_tests.py", line 1218, in _test_pkinit_smartcard_required_must_change
    kdc_exchange_dict = self._pkinit_req(client_creds, krbtgt_creds,
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/pkinit_tests.py", line 2002, in _pkinit_req
    rep = self._generic_kdc_exchange(kdc_exchange_dict,
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/raw_testcase.py", line 3227, in _generic_kdc_exchange
    return check_rep_fn(kdc_exchange_dict, callback_dict, rep)
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/raw_testcase.py", line 4050, in generic_check_kdc_rep
    check_kdc_private_fn(kdc_exchange_dict, callback_dict,
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/raw_testcase.py", line 4340, in generic_check_kdc_private
    self.check_pac_buffers(pac_data, kdc_exchange_dict)
  File "/m/bjacke/a425/b2137588/samba-def-build/bin/python/samba/tests/krb5/raw_testcase.py", line 5054, in check_pac_buffers
    self.assertEqual(creds.get_nt_hash(), nt_password)
AssertionError: b'\xf7=\xb6iq\xa5\x87\x12\x0b,\x85\x0c\x13\x8f-E' != b'\x16\x8bR\x05N)P\xb2b\x99\xa6s_\xb4\x02\x14'

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
Comment 1 Douglas Bagnall 2026-09-22 10:34:07 UTC
Is it always test_pkinit_smartcard_required_must_change_short_tgt or sometimes other tests?
Comment 2 Björn Jacke 2026-09-22 15:50:01 UTC
yes, test_pkinit_smartcard_required_must_change_short_tgt was always the one, which failed for me with samba.tests.krb5.pkinit_tests.