Bug 16233 - "getwd cache" removal needs more work
Summary: "getwd cache" removal needs more work
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.25.0rc*
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: David Mulder
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-09-06 14:49 UTC by Björn Jacke
Modified: 2026-09-24 21:58 UTC (History)
2 users (show)

See Also:


Attachments
Patch (846 bytes, patch)
2026-09-08 07:39 UTC, Volker Lendecke
bjacke: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2026-09-06 14:49:38 UTC
"getwd cache" was removed but the removal is not listed in WHATSNEW and the option is still listed in libgpo/admx/samba.admx. Both should get fixed for the final release.
Comment 1 Volker Lendecke 2026-09-08 07:39:13 UTC
Created attachment 19195 [details]
Patch
Comment 2 Volker Lendecke 2026-09-08 07:40:58 UTC
Attached find a patch for mentioning the removed parameter in WHATSNEW. To be honest, I need assistance how to remove the file from both the English as well as the Russian admx files. I could of course edit the text by hand, but I have no clue about the internal structure of the (what looks to me like) XML, so I really don't know if I would leave correct XML behind.
Comment 3 Björn Jacke 2026-09-08 16:02:36 UTC
git blame?
Comment 4 Samba QA Contact 2026-09-08 16:05:15 UTC
This bug was referenced in samba v4-25-test:

fc973f7fac40bb20118ea61a958a888de08ab26c
Comment 5 Volker Lendecke 2026-09-08 16:13:45 UTC
git blame points at cb994befb0c89c8a, which does not give me enough hints towards how to recreate the files using the group management console in Windows. 

Is this a release blocker?
Comment 6 Björn Jacke 2026-09-08 16:22:01 UTC
I meant git blame to find the assistance person mainly. It would be really good to get deleted parameters out of out gpo file for new .0 releases (but it's not strictly a blocker...)
Comment 7 Volker Lendecke 2026-09-09 08:25:28 UTC
Hi, David!

Do you remember how you created the admx files? Can you either tell me how to do that or recreate them?

Thanks, Volker
Comment 8 David Mulder 2026-09-09 14:46:01 UTC
(In reply to Volker Lendecke from comment #7)

I used ADMX Migrator. It's a legacy Windows tool. You used to be able to download it from the Microsoft website. Looks like you can still find it on archive sites.

I ran it in Wine, and it worked just fine.
Comment 9 Volker Lendecke 2026-09-10 10:51:17 UTC
Thanks David.
Comment 10 Volker Lendecke 2026-09-10 11:20:51 UTC
This problem is much larger. libgpo/admx is basically unmaintained, but in theory should follow smb.conf. For example

git grep "ldap ssl ads"

shows the same, but it also shows that this is still referenced in a different manpage.
Comment 11 Volker Lendecke 2026-09-10 11:26:38 UTC
Next one: In addition to libgpo/admx/en-US/samba.adml, which I would dare to keep up to date. However I don't speak Russian, so I would not feel confident maintaining that one.
Comment 12 Björn Jacke 2026-09-19 10:13:18 UTC
Just some thoughts: Isn't this a typical case for maintaining i18n with gettext here? It isn't easy for us to keep the English version up-to-date, it seems to be a really bad idea to try to maintain another version in a different language. Or maybe we should just drop the translation, I'm not sure if it's worth the hassle. Having outdated and diverging files here is definetely the worst option.
Comment 13 Samba QA Contact 2026-09-24 21:58:52 UTC
This bug was referenced in samba v4-25-stable (Release samba-4.25.0):

fc973f7fac40bb20118ea61a958a888de08ab26c