Bug 16218 - vfs_ceph_rgw: Fix xattr handling and add missing VFS methods (flistxattr, fs_capabilities)
Summary: vfs_ceph_rgw: Fix xattr handling and add missing VFS methods (flistxattr, fs_...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.25.0rc*
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba release manager
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-08-11 04:58 UTC by Anoop C S
Modified: 2026-09-06 15:37 UTC (History)
1 user (show)

See Also:


Attachments
patch from master for v4-25-test (12.11 KB, patch)
2026-08-11 08:11 UTC, Anoop C S
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anoop C S 2026-08-11 04:58:52 UTC
The vfs_ceph_rgw VFS module has several issues related to extended attribute handling and missing VFS method implementations:

1. fgetxattr returns wrong status for non-existing xattrs: The rgw_getxattrs() API returns 0 both when an xattr exists (callback invoked) and when it does not (callback not invoked). The module treated any rc == 0 as success, so the upper layer received no data and no error instead of the expected NT_STATUS_OBJECT_NAME_NOT_FOUND.

2. flistxattr is not implemented: The module registered vfs_not_implemented_flistxattr, causing any attempt to enumerate extended attributes to fail.

3. fs_capabilities is not implemented: The module registered vfs_not_implemented_fs_capabilities and hardcoded FsCapabilities to 0.
Comment 1 Samba QA Contact 2026-08-11 06:07:02 UTC
This bug was referenced in samba master:

9867d4d99c9337a3e820b07f3e0f7d9b756524f6
3796c788ac879bae0a66e3d7f44b94e68f251b02
e39f85d383ba15dffc0b8fd109b361cfb89afee7
Comment 2 Anoop C S 2026-08-11 08:11:40 UTC
Created attachment 19166 [details]
patch from master for v4-25-test
Comment 3 Guenther Deschner 2026-08-11 08:38:13 UTC
Comment on attachment 19166 [details]
patch from master for v4-25-test

LGTM, RB+
Comment 4 Guenther Deschner 2026-08-11 08:39:11 UTC
Björn, please add to v4-25-test
Comment 5 Samba QA Contact 2026-08-11 20:25:04 UTC
This bug was referenced in samba v4-25-test:

0601b5cab51959d0124789e34def8a9ab550b24b
6b8676194f60051246af618a43376890eb84214b
f73e0f70ff72ea062c8c8f0a1e0c096a9e475b05
Comment 6 Samba QA Contact 2026-09-06 15:37:17 UTC
This bug was referenced in samba v4-25-stable (Release samba-4.25.0rc2):

0601b5cab51959d0124789e34def8a9ab550b24b
6b8676194f60051246af618a43376890eb84214b
f73e0f70ff72ea062c8c8f0a1e0c096a9e475b05