Bug 16097 - POSIX ACL backend silently discards erros when processing NT ACLs with non-canonical ordering
Summary: POSIX ACL backend silently discards erros when processing NT ACLs with non-ca...
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-06-08 15:26 UTC by Ralph Böhme
Modified: 2026-06-27 09:39 UTC (History)
1 user (show)

See Also:

Attachments
Patch for 4.23 and 4.24 cherry-picked from master (16.23 KB, patch)
2026-06-27 09:39 UTC, Ralph Böhme 		slow: review? (asn)
 Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2026-06-08 15:26:09 UTC 
If a Windows ACLs is non-canonically ordered (ie deny ACE after an allow ACE), our ACL mapping code from Win to POSIX chokes on the non-canonical ordering and fails in create_canon_ace_lists(), but this error is ignored in the caller so the ACL-set is reported as successful to the caller while no ACL was set in the backend.

Have patch, need bugnumber.
Comment 1 Samba QA Contact 2026-06-26 12:51:03 UTC 
This bug was referenced in samba master:

8d5674bccfdfecde34ea7a1b1fd384b0cff60d82
64a20d65df6c828dee1ca3230c82868969a60afc
1d19ca727c6f6fc6fec4a070dc90b04058b316d8
4cc867cc6fe1afef85b7f88b55e4c8e0058fc7a4
Comment 2 Ralph Böhme 2026-06-27 09:39:54 UTC 
Created attachment 19041 [details]
Patch for 4.23 and 4.24 cherry-picked from master