Bug 16000 - vfs_aio_ratelimit: introduce burst-aware and persistent state model
Summary: vfs_aio_ratelimit: introduce burst-aware and persistent state model
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: 4.24
Assignee: Samba release manager
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-02-13 06:30 UTC by Avan
Modified: 2026-02-28 05:21 UTC (History)
1 user (show)

See Also:


Attachments
patch from master for v4-24-test (46.85 KB, patch)
2026-02-27 12:24 UTC, Guenther Deschner
anoopcs: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Avan 2026-02-13 06:30:53 UTC
Enhance vfs_aio_ratelimit with configurable burst support, persistent rate state, and improved bandwidth configuration.

The enhancement should introduce:

- Configurable burst allowance for read and write operations.
- Persistent rate-limiter state per share to ensure consistent enforcement across restarts.
- Support for human-readable bandwidth values (e.g., 1M, 500K, 2G) while maintaining backward compatibility.
Comment 1 Björn Jacke 2026-02-13 15:25:34 UTC
4.24 is rc state already; feature enhancements will go to master and be part of the next stable release in 6 months.
Comment 2 Samba QA Contact 2026-02-27 11:53:04 UTC
This bug was referenced in samba master:

f6a67c361bcb0d9f4a7f451dcfda800775b5be13
306612e09c082282f39789c426ea85cc7e2bb6e3
d6332b2caf03e4fcbed0a67208251a27601c527d
9b54d8beaefd9b835b971dd0370d3a1f198121d8
83f4b51175cdaa20039de7e823bc4c6a15893628
Comment 3 Guenther Deschner 2026-02-27 12:24:51 UTC
Created attachment 18874 [details]
patch from master for v4-24-test
Comment 4 Guenther Deschner 2026-02-27 13:32:09 UTC
(In reply to Björn Jacke from comment #1)

Björn, this module just got introduced within the 4.24.0 rc cycle and we had to still change some smb.conf config parameters and fix some of the inner workings of that module to make it properly work. I believe in that case we should really avoid creating a painful config incompatibility while we still can resolve it prior to the 4.24.0 final release. I agree that other upcoming major enhancements (e.g. clustering support) for that module need to go into the next release branch.
Comment 5 Anoop C S 2026-02-28 05:21:43 UTC
Re-assigning for 4.24 inclusion.