Bug 15978 - leases torture test flappy (marked flappy)
Summary: leases torture test flappy (marked flappy)
Status: REOPENED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: 4.23.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-01-22 14:01 UTC by Björn Jacke
Modified: 2026-06-30 15:44 UTC (History)
1 user (show)

See Also:


Attachments
backport fix for 4.24 and 4.23 (1.01 KB, patch)
2026-02-23 12:41 UTC, Björn Jacke
slow: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2026-01-22 14:01:24 UTC
the leases test should become more stable or get marked flapping, this needs also be fixed for the release branches then:

Waiting for a potential lease break...
transport[0x58a5eeda3e80] Skip acking to 0x1 (R) in lease handler
Got 1 lease breaks
Got break for file 2
Doing additional open after first break
Waiting for a potential lease break...
... waiting for a lease break timed out
Got break for file 2
WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for lease_break_info.count got 0x0 - should be 0x1

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for (&lease_break_info.lease_break)->new_lease_state got 0x0 - should be 0x1

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for (&lease_break_info.lease_break)->current_lease.lease_state got 0x0 - should be 0x3

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for (&lease_break_info.lease_break)->current_lease.lease_key.data[0] got 0x0 - should be 0xfeedbead

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for (&lease_break_info.lease_break)->current_lease.lease_key.data[1] got 0x0 - should be 0x1124152

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for (&lease_break_info.lease_break)->break_flags got 0x0 - should be 0x1

WARNING!: (../../source4/torture/smb2/lease.c:5969): wrong value for lease_break_info.lease_break.new_epoch got 0x0 - should be 0x4

WARNING!: ../../source4/torture/smb2/lease.c:5981: status was NT_STATUS_FILE_CLOSED, expected NT_STATUS_OK: smb2_util_close failed

UNEXPECTED(failure): samba3.smb2.lease.rename_dir_openfile(fileserver)
REASON: Exception: Exception: ../../source4/torture/smb2/lease.c:6086: Expression `ret' failed: test failed

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
Comment 1 Björn Jacke 2026-02-18 12:53:45 UTC
ping, this one is really causing most of the autobuild failures.
Comment 2 Björn Jacke 2026-02-23 10:26:26 UTC
If fixing is not possible, please mark this test as flapping.
Comment 3 Samba QA Contact 2026-02-23 12:38:03 UTC
This bug was referenced in samba master:

437436832fdddfda692fac01452ad7bc4a0b6e3d
Comment 4 Björn Jacke 2026-02-23 12:41:54 UTC
Created attachment 18863 [details]
backport fix for 4.24 and 4.23
Comment 5 Samba QA Contact 2026-02-23 15:21:28 UTC
This bug was referenced in samba v4-24-test:

a296e71d3bd6cef20259e397f6bf4559ba0e2826
Comment 6 Samba QA Contact 2026-02-23 20:07:20 UTC
This bug was referenced in samba v4-24-stable (Release samba-4.24.0rc3):

a296e71d3bd6cef20259e397f6bf4559ba0e2826
Comment 7 Samba QA Contact 2026-02-27 07:39:53 UTC
This bug was referenced in samba v4-23-test:

269c91deb4860e7720186fc5430b3407edc23fdf
Comment 8 Samba QA Contact 2026-02-27 09:36:22 UTC
This bug was referenced in samba v4-23-stable (Release samba-4.23.6):

269c91deb4860e7720186fc5430b3407edc23fdf
Comment 9 Samba QA Contact 2026-04-08 17:41:28 UTC
This bug was referenced in samba v4-22-test:

4146d3a90aa0483bced13cd3327c70218dd8132c
Comment 10 Samba QA Contact 2026-04-09 09:36:07 UTC
This bug was referenced in samba v4-22-stable (Release samba-4.22.9):

4146d3a90aa0483bced13cd3327c70218dd8132c
Comment 11 Björn Jacke 2026-04-10 12:26:18 UTC
I closed this accidently, leaving it up to you, Ralph, if this should stay flappy or if you want to look into the actual problem of the test later on.
Comment 12 Björn Jacke 2026-06-30 15:40:17 UTC
still failing builds, for example for 4.24 just got this:

[72(370)/130 at 4m32s] samba3.smb2.lease(fileserver)
Waiting for a potential lease break...
transport[0x60489cb6daa0] Skip acking to 0x1 (R) in lease handler
Got 1 lease breaks
Waiting for a potential lease break...
transport[0x60489cb6daa0] Skip acking to 0x1 (R) in lease handler
Got 1 lease breaks
WARNING!: (../../source4/torture/smb2/lease.c:6364): wrong value for (&lease_break_info.lease_break)->current_lease.lease_key.data[0] got 0x1 - should be 0x2

Waiting for a potential lease break...
... waiting for a lease break timed out
UNEXPECTED(failure): samba3.smb2.lease.two-leases(fileserver)
REASON: Exception: Exception: (../../source4/torture/smb2/lease.c:6364): wrong value for (&lease_break_info.lease_break)->current_lease.lease_key.data[1] got 0xfffffffe - should be 0xfffffffd

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
Comment 13 Ralph Böhme 2026-06-30 15:44:01 UTC
That's another test that failed. This time its two-leases, earlier it has been rename_dir_openfile.