Bug 15965 - samba-tool domain provision --function-level does not support 2012_R2
Summary: samba-tool domain provision --function-level does not support 2012_R2
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.22.6
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-18 01:22 UTC by Mike Liu
Modified: 2025-12-18 03:33 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Liu 2025-12-18 01:22:14 UTC
domain provision cannot directly specify --function-level=2012_R2.
You must first create the domain with 2008_R2 and then raise the domain level using 'domain level raise --domain-level=2012_R2'.

Although manually modifying the choices allows domain provisioning with --function-level=2012_R2 as shown in the changes below, 
I would like to know what considerations led to the decision that provisioning does not support --function-level=2012_R2?

----
python/samba/netcmd/domain/provision.py

Option("--function-level", type="choice", metavar="FOR-FUN-LEVEL",
-      choices=["2000", "2003", "2008", "2008_R2", "2016"],
+      choices=["2000", "2003", "2008", "2008_R2", "2012", "2012_R2" "2016"],
Comment 1 Douglas Bagnall 2025-12-18 03:33:55 UTC
I think at the time this was added we didn't completely support 2012_R2, but we also *nearly* supported 2016, and we added this to test a server that claims FL 2016.

That was commit f94f174db452015c3032e725e13f485bd51413dc.

Since then we more fully support 2012_R2.