Bug 15961 - libldb requires linking libreplace on Linux
Summary: libldb requires linking libreplace on Linux
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-02 13:07 UTC by Andreas Schneider
Modified: 2025-12-18 16:18 UTC (History)
2 users (show)

See Also:


Attachments
patch for 4.23 and 4.22 (1.63 KB, patch)
2025-12-08 08:06 UTC, Andreas Schneider
pfilipensky: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2025-12-02 13:07:23 UTC
Packaging Samba isn't an easy task.

libldb has been inherited to Samba again. That however shouldn't be seen as an invitation to add dependencies to other Samba libraries. The reason is that libdlb is still used by other projects like sssd.

Using internals from libreplace, should be avoided. If possible libldb should not link against it.

Example:

Upgrading:
 libldb                                     x86_64
 4.22.4-6.el9_7                           rhel-9-for-x86_64-baseos-rpms
                     185 k
 libtalloc                                  x86_64
 2.4.3-1.el9                              rhel-9-for-x86_64-baseos-rpms
                      34 k
 libtdb                                     x86_64
 1.4.13-1.el9                             rhel-9-for-x86_64-baseos-rpms
                      54 k
 libtevent                                  x86_64
 0.16.2-1.el9                             rhel-9-for-x86_64-baseos-rpms
                      51 k
Installing dependencies:
 avahi-libs                                 x86_64
 0.8-23.el9                               rhel-9-for-x86_64-baseos-rpms
                      67 k
 libicu                                     x86_64
 67.1-10.el9_6                            rhel-9-for-x86_64-baseos-rpms
                     9.6 M
 libtirpc                                   x86_64
 1.3.3-9.el9                              rhel-9-for-x86_64-baseos-rpms
                      97 k
 libwbclient                                x86_64
 4.22.4-6.el9_7                           rhel-9-for-x86_64-baseos-rpms
                      42 k
 *samba-client-libs                          x86_64           *
   4.22.4-6.el9_7                           rhel-9-for-x86_64-baseos-rpms
                       5.4 M
 *samba-common                               noarch           *
   4.22.4-6.el9_7                           rhel-9-for-x86_64-baseos-rpms
                       175 k
 *samba-common-libs                          x86_64            *
   4.22.4-6.el9_7                           rhel-9-for-x86_64-baseos-rpms
                       104 k
Comment 1 Samba QA Contact 2025-12-03 10:55:13 UTC
This bug was referenced in samba master:

1bb25c0e01d35b1adb3137cb193de27f5c5a65f0
Comment 2 Andreas Schneider 2025-12-08 08:06:29 UTC
Created attachment 18785 [details]
patch for 4.23 and 4.22
Comment 3 Pavel Filipenský 2025-12-09 08:15:03 UTC
Comment on attachment 18785 [details]
patch for 4.23 and 4.22

Patch is verified for both 4.22 and 4.23
Comment 4 Pavel Filipenský 2025-12-09 08:15:26 UTC
Jule please add the patch to both v4.22-test and v4.23-test.
Comment 5 Jule Anger 2025-12-11 12:33:09 UTC
Pushed to autobuild-v4-{23,22}-test.
Comment 6 Samba QA Contact 2025-12-11 17:01:12 UTC
This bug was referenced in samba v4-23-test:

82bcd3d80464713b6d88ca3e830265d03d26f1a2
Comment 7 Samba QA Contact 2025-12-12 13:57:30 UTC
This bug was referenced in samba v4-23-stable (Release samba-4.23.4):

82bcd3d80464713b6d88ca3e830265d03d26f1a2
Comment 8 Samba QA Contact 2025-12-18 10:00:04 UTC
This bug was referenced in samba v4-22-test:

80e60822bd21b8487b0908e25af3e5f48e7d47f6
Comment 9 Samba QA Contact 2025-12-18 16:14:14 UTC
This bug was referenced in samba v4-22-stable (Release samba-4.22.7):

80e60822bd21b8487b0908e25af3e5f48e7d47f6
Comment 10 Jule Anger 2025-12-18 16:18:57 UTC
Closing out bug report.

Thanks!