Bug 15924 - samba-4.23.1: 2 * Non-boolean value returned from function returning bool
Summary: samba-4.23.1: 2 * Non-boolean value returned from function returning bool
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-28 14:55 UTC by David Binderman
Modified: 2026-01-15 22:39 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2025-09-28 14:55:55 UTC 
Static analyser cppcheck says:

1.

samba-4.23.1/source3/utils/status_json.c:1385:3: style: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]

2.

samba-4.23.1/source4/client/http_test.c:85:3: style: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
Comment 1 Jennifer Sutton 2025-09-28 20:30:06 UTC 
Thanks. Both of these should be changed to `return false`.
Comment 2 Samba QA Contact 2026-01-15 09:19:03 UTC 
This bug was referenced in samba master:

a7e7a68b80cbf7fec83e75cc592cda0bcdfb3766
90c806d3083d4e88d8c6626becd50b322117f213