Bug 15854 - samba-tool cannot add user to group whose name is exactly 16 characters long
Summary: samba-tool cannot add user to group whose name is exactly 16 characters long
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.22.0
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-06 11:44 UTC by Richard Schütz
Modified: 2025-05-13 22:21 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Schütz 2025-05-06 11:44:43 UTC 
# samba-tool group addmembers abcdefghijklmnop user
ERROR: Failed to add members ['user'] to group "abcdefghijklmnop" - (32, "Base-DN '<GUID=64636261-6665-6867-696a-6b6c6d6e6f70>' not found")

This is a regression caused by commit 21a88df032c6e481b547fad2c48d14243a514035. add_remove_group_members() now tries to interpret the group name as GUID first, which eventually succeeds in GUID_from_data_blob() and GUID_from_ndr_blob() for arbitrary strings with 16 characters.
Comment 1 Jennifer Sutton 2025-05-08 05:16:39 UTC 
Does add_remove_group_members() need to support SIDs and GUIDs in the first place when it also supports '<SID=>' and '<GUID=>' DN syntax?