Bug 15829 - samba-tool gpo backup creates entity backups it can't read
Summary: samba-tool gpo backup creates entity backups it can't read
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Python (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Douglas Bagnall
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-17 02:46 UTC by Douglas Bagnall
Modified: 2025-04-17 17:15 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2025-03-17 02:46:04 UTC 
We have been putting line returns inside our entities backup file, like 

    <!ENTITY foo "bar"
    ><!ENTITY baz "quux"
    ><!ENTITY ...

which is valid XML, but rejected by a regular expression we use in samba-tool to check the validity of the file. That means we can't restore the backup.

We have a test to prove we don't do this, but the test is broken.

It seesm like this has been reported on the list:

https://lists.samba.org/archive/samba/2023-September/246510.html

Patches coming soon.
Comment 1 Samba QA Contact 2025-03-25 05:22:22 UTC 
This bug was referenced in samba master:

6b619b568f6661d3a5f0701cdfaf1e1e4943ff6f
65751f2562f98bd7fd0734dc00784e6395d76322
6107656ebc8d092b2c1907940b2486ab0265aad9
Comment 2 Samba QA Contact 2025-04-17 12:50:23 UTC 
This bug was referenced in samba v4-22-test:

a07c0f655669e8b090f85339a0db455115deec3f
16defe083869a3134a6e65430baa84e64f4e9f57
f8cbabc59858b8fea57014a5f3e99479b3e886ff
Comment 3 Samba QA Contact 2025-04-17 12:54:30 UTC 
This bug was referenced in samba v4-21-test:

f5230c26adb5ff87ee9a092f0e96542536fe87b5
0b7151d073d1b0a6076562e7052be64c8e9944b7
f3b9da3179e87f3c7ddbc01b83cf1fceb1f2fa1c
Comment 4 Samba QA Contact 2025-04-17 17:15:43 UTC 
This bug was referenced in samba v4-22-stable (Release samba-4.22.1):

a07c0f655669e8b090f85339a0db455115deec3f
16defe083869a3134a6e65430baa84e64f4e9f57
f8cbabc59858b8fea57014a5f3e99479b3e886ff