Bug 15818 - vfs_ceph_new module does not work with other modules for snapshot management
Summary: vfs_ceph_new module does not work with other modules for snapshot management
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.22.0rc4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-04 06:29 UTC by Anoop C S
Modified: 2025-03-13 17:07 UTC (History)
1 user (show)

See Also:

Attachments
patch from master for v4-22-test (12.78 KB, patch)
2025-03-13 04:51 UTC, Anoop C S 		gd: review+
Details
patch from master for v4-21-test (12.78 KB, patch)
2025-03-13 04:51 UTC, Anoop C S 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anoop C S 2025-03-04 06:29:36 UTC 
Be it vfs_shadow_copy2 or vfs_ceph_snapshots, vfs_ceph_new couldn't list the snapshots as previous versions. Sample configurations:


[cephfs-subvol-new]
	comment = For samba share of subvolume subvol
	path = /volumes/_nogroup/subvol/d2916e6d-a054-41f1-ac77-17ee77f22365
	read only = No
	vfs objects = ceph_snapshots ceph_new
	ceph_new:config_file = /etc/ceph/ceph.conf
	ceph_new:user_id = foo
	ceph_new:filesystem = cephvol

[cephfs-subvol-new-shadowcopy2]
	comment = For samba share of subvolume subvol
	path = /volumes/_nogroup/subvol/d2916e6d-a054-41f1-ac77-17ee77f22365
	read only = No
	vfs objects = shadow_copy2 ceph_new
	shadow:snapdir = .snap
	shadow:snapdirseverywhere = yes
	shadow:format = _snap_%Y-%m-%d-%H%M%S_1099511627778
	ceph_new:config_file = /etc/ceph/ceph.conf
	ceph_new:user_id = foo
	ceph_new:filesystem = cephvol

Sample snapshots available within the file system:
$ smbclient \\\\192.168.122.101\\cephfs-subvol-new -U root%smb -c "cd .snap;ls"
  .                                   D        0  Mon Mar  3 22:45:20 2025
  ..                                  D        0  Fri Oct 11 15:25:07 2024
  _snap_2025-02-06-155603_1099511627778      D        0  Thu Jan 30 17:38:58 2025
  _snap_2025-02-06-160806_1099511627778      D        0  Thu Feb  6 16:07:20 2025
  _snap_2025-02-12-161003_1099511627778      D        0  Sat Feb  8 18:48:03 2025
  _snap_2025-02-12-163817_1099511627778      D        0  Sat Feb  8 18:48:03 2025
  _snap_2025-02-12-172301_1099511627778      D        0  Wed Feb 12 17:22:04 2025
  _snap_2025-02-13-161612_1099511627778      D        0  Thu Feb 13 15:23:12 2025
  _snap@2025-02-21-170620_1099511627778      D        0  Thu Feb 20 10:27:27 2025
  _snap_GMT_2025-02-21-173206_1099511627778      D        0  Thu Feb 20 10:27:27 2025
  _snap#_GMT_2025-02-21-180623_1099511627778      D        0  Thu Feb 20 10:27:27 2025
  _snap_1099511627778                 D        0  Thu Feb 20 10:27:27 2025

		4902912 blocks of size 1024. 4902912 blocks available

$ smbclient \\\\192.168.122.101\\cephfs-subvol-new -U root%smb -c "cd dir/.snap;ls"
  .                                   D        0  Mon Mar  3 22:45:20 2025
  ..                                  D        0  Thu Feb 20 10:27:27 2025
  _snap_2025-02-06-160806_1099511627778      D        0  Thu Feb  6 16:07:57 2025
  _snap_2025-02-12-161003_1099511627778      D        0  Thu Feb  6 16:07:57 2025
  _snap_2025-02-12-163817_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap_2025-02-12-172301_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap_2025-02-13-161612_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap@2025-02-21-170620_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap_GMT_2025-02-21-173206_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap#_GMT_2025-02-21-180623_1099511627778      D        0  Wed Feb 12 16:37:48 2025
  _snap_1099511627778                 D        0  Wed Feb 12 16:37:48 2025

		4902912 blocks of size 1024. 4902912 blocks available
Comment 1 Samba QA Contact 2025-03-07 18:21:03 UTC 
This bug was referenced in samba master:

c5ddd94a08503a52914ce351ebf1083178e8c8bc
ee1c3e1db9a2d12ba6d9dd24faccf0020b1daf0d
9341d7fb466c95ea5aa0643049ce2a1f4183b9d0
a96f0542c8317a7dd0470b32350de6893fd98723
Comment 2 Anoop C S 2025-03-13 04:51:18 UTC 
Created attachment 18601 [details]
patch from master for v4-22-test
Comment 3 Anoop C S 2025-03-13 04:51:41 UTC 
Created attachment 18602 [details]
patch from master for v4-21-test
Comment 4 Guenther Deschner 2025-03-13 11:47:28 UTC 
Comment on attachment 18601 [details]
patch from master for v4-22-test

LGTM, RB+
Comment 5 Guenther Deschner 2025-03-13 11:47:44 UTC 
Comment on attachment 18602 [details]
patch from master for v4-21-test

LGTM, RB+
Comment 6 Guenther Deschner 2025-03-13 11:48:10 UTC 
Jule, please add to v4-21 and v4-22. Thanks!
Comment 7 Samba QA Contact 2025-03-13 16:59:22 UTC 
This bug was referenced in samba v4-21-test:

08f2d5abca6b44c5cae1e476a591495ce76a3179
6b997c180f52740014724f2351683f409e74cfff
d9151f66cc39be0653618ac299c2a9b2e587ef28
40d2b73f24b2a780d3bf278f177206a0a107fdb1
Comment 8 Samba QA Contact 2025-03-13 17:07:14 UTC 
This bug was referenced in samba v4-22-test:

4e9eb916024a61fdebb3aedd10e972ac957cc8c1
8b38092890dc18183ed3190e6731f4a21d341d9e
d26177dcaeb757e01a480ebd7a7a9dd7528ddbad
bf440caab97778ae6ce312d4905585abe277884c