Bug 15769 - The values from hresult_errstr_const and hresult_errstr are reversed in 4.20 and 4.21
Summary: The values from hresult_errstr_const and hresult_errstr are reversed in 4.20 ...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.21.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-16 13:43 UTC by Stefan Metzmacher
Modified: 2025-01-17 12:53 UTC (History)
1 user (show)

See Also:

Attachments
Patch for v4-21-test (1.99 KB, patch)
2024-12-19 09:14 UTC, Stefan Metzmacher 		gd: review+
Details
Patch for v4-20-test (1.99 KB, patch)
2024-12-19 09:14 UTC, Stefan Metzmacher 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2024-12-16 13:43:15 UTC 
hresult_errstr() should return values like "HRES_SEC_E_WRONG_PRINCIPAL",
while hresult_errstr_const() should return "The target principal name is incorrect."
Comment 1 Samba QA Contact 2024-12-18 18:31:03 UTC 
This bug was referenced in samba master:

6e0e9c4efc86f5ec4566aa0220ed4a74ad5436c1
Comment 2 Stefan Metzmacher 2024-12-19 09:14:16 UTC 
Created attachment 18516 [details]
Patch for v4-21-test
Comment 3 Stefan Metzmacher 2024-12-19 09:14:48 UTC 
Created attachment 18517 [details]
Patch for v4-20-test
Comment 4 Guenther Deschner 2025-01-08 13:03:26 UTC 
Comment on attachment 18516 [details]
Patch for v4-21-test

LGTM, RB+
Comment 5 Guenther Deschner 2025-01-08 13:03:37 UTC 
Comment on attachment 18517 [details]
Patch for v4-20-test

LGTM, RB+
Comment 6 Guenther Deschner 2025-01-08 13:05:13 UTC 
Jule. please add to 4.20 and 4.21. Thanks!
Comment 7 Jule Anger 2025-01-09 08:36:07 UTC 
Pushed to autobuild-v4-{21,20}-test.
Comment 8 Samba QA Contact 2025-01-09 09:57:11 UTC 
This bug was referenced in samba v4-20-test:

a015ffb3dea44bbe4c77f3b626accd5dd7c273d6
Comment 9 Samba QA Contact 2025-01-09 11:17:12 UTC 
This bug was referenced in samba v4-21-test:

e903d8aa33fdac1c2104d02cd3665fdf39efcfc6
Comment 10 Jule Anger 2025-01-17 12:53:03 UTC 
Closing out bug report.

Thanks!