Bug 15729 - LGPL License files not included in libtalloc and libtevent releases
Summary: LGPL License files not included in libtalloc and libtevent releases
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: x86 Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Andreas Schneider
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-30 23:07 UTC by mpearson-lenovo@squebb.ca
Modified: 2024-12-13 12:21 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mpearson-lenovo@squebb.ca 2024-09-30 23:07:41 UTC
Apologies for the joint bug - but I couldn't see how to raise one for tevent and as it's the same issue as for libtalloc I'm hoping I can combine. Let me know if a separate tevent bug is needed (and if possible what project/component to raise it against)

I've been doing open-source compliance review for the Fedora preload used on Lenovo laptops, and for the libtalloc and libtevent packages the license file is not available. It seems it's not available in the upstream releases.

I believe the source code in these projects is all LGPLv3 - would it be possible to add a COPYING.LESSER file in the releases for these two components please?

Thanks!
Mark
Comment 1 mpearson-lenovo@squebb.ca 2024-10-01 19:13:31 UTC
can I add libtdb to this list as well
Thanks
Mark
Comment 2 Douglas Bagnall 2024-11-28 22:17:42 UTC
Indeed, I don't think we have a copy of LGPLv3 in the source tree.

This probably also affects ldb and tevent.

We also have LGPLv3 headers in files in these places:

lib/addns
lib/async_req
lib/compression
lib/crypto
lib/ldb-samba
lib/replace
lib/mscat
lib/util
nsswitch
script/generate_param.py

but we don't release tarballs for those, as far as I know.

There are also a few files, like
source4/dsdb/samdb/ldb_modules/paged_results.c
that have LGPLv3 headers perhaps by mistake.

The correct bugzilla category is perhaps "Samba 4.1 and newer" -> "build", to which I shall now attempt to shift it.
Comment 3 Douglas Bagnall 2024-11-28 22:36:00 UTC
(In reply to Douglas Bagnall from comment #2)
> This probably also affects ldb and tevent.

Yeah, I see tevent is the one you mentioned!

You ask for "COPYING.LESSER", but I see in some files we mention "COPYING.LIB".
Does it matter which?
Comment 4 Andreas Schneider 2024-11-29 09:08:48 UTC
The best is to create lib/talloc/LICENSE, lib/tevent/LICENSE and lib/ldb/LICENSE with the correct content.
Comment 5 mpearson-lenovo@squebb.ca 2024-12-11 13:40:39 UTC
> You ask for "COPYING.LESSER", but I see in some files we mention "COPYING.LIB".
> Does it matter which?

Doesn't matter - whatever works for you guys (we have a tool that scans the file and determines what the licence actually is, as part of the compliance process).
Comment 6 Samba QA Contact 2024-12-12 15:01:05 UTC
This bug was referenced in samba master:

cd0fb59568d525cb261ac711bf421020ffdfe575
24494f9ff720ba6a18db4163832e21106a7b4915
d1849ba12f576f28b3def2253a76b7706200e490
d091182156f6467dbf19ac45f8b48de7e35dfc7a
Comment 7 Andreas Schneider 2024-12-13 09:07:51 UTC
Will be fixed when Samba 4.22 will be released.
Comment 8 mpearson-lenovo@squebb.ca 2024-12-13 12:21:52 UTC
Awesome - thank you!
Mark