The static analyzer has detected NULL_AFTER_DEREF: dPointer 'fsp', which is dereferenced at files.c:99 by passing as 1st parameter to function 'fsp_set_gen_id' at files.c:472, is compared to a NULL value at files.c:576. The correctness of 'fsp' is checked at files.c:467, so the code at files.c:576-578 looks redundant. By the way, in other branches this nuance has been fixed. Foe example, there is no such redundant code [here](https://github.com/samba-team/samba/commit/f292b1ae0025af6d7432116aee3decb16a1699cf). GitHub: 1) files.c:472 https://github.com/samba-team/samba/blob/225a003a043eee399b6d266d94440c399b6877e4/source3/smbd/files.c#L472 2) files.c:576-578 https://github.com/samba-team/samba/blob/225a003a043eee399b6d266d94440c399b6877e4/source3/smbd/files.c#L576-L578 3) files.c:466-469 https://github.com/samba-team/samba/blob/225a003a043eee399b6d266d94440c399b6877e4/source3/smbd/files.c#L466C1-L469C3 Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author E. Bykhanova (e.bykhanova@fobos-nt.ru).