Bug 15351 - large_ldap test is unreliable
Summary: large_ldap test is unreliable
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.18.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-05 21:02 UTC by Andrew Bartlett
Modified: 2023-05-11 07:11 UTC (History)
1 user (show)

See Also:

Attachments
patch for Samba 4.18 and earlier versions (3.72 KB, patch)
2023-04-06 02:03 UTC, Andrew Bartlett 		jsutton: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2023-04-05 21:02:22 UTC 
The ldap_timeout test in large_ldap.py tries to pick an LDAP expression that will takes > 5seconds and < 20 seconds. 

This is impossible, and this bug is for tweaks that make this reliable, or an overhaul that fixes the problem properly.

A future fix should also only run this aspect of the tests once, not once per encryption scheme, as the timeout behaviour is not related to the wrapping (unlike other aspects of that testsuite).
Comment 1 Samba QA Contact 2023-04-06 01:34:05 UTC 
This bug was referenced in samba master:

e1c0c2066c2f29bb614e3386b796eec3cb289aea
479634e4cd6543d489eb4700aebde1a479b94fe5
Comment 2 Andrew Bartlett 2023-04-06 02:03:39 UTC 
Created attachment 17854 [details]
patch for Samba 4.18 and earlier versions

This should apply to 4.17 and 4.16 also.
Comment 3 Jule Anger 2023-04-11 07:28:47 UTC 
Pushed to autobuild-v4-{18,17}-test.
Comment 4 Samba QA Contact 2023-04-11 08:37:03 UTC 
This bug was referenced in samba v4-18-test:

330958ae80495311ae1718bfe021c05ecec77e05
dea4cb70045503fe882c2d4d24bfc07ce502c673
Comment 5 Samba QA Contact 2023-04-11 16:29:28 UTC 
This bug was referenced in samba v4-17-test:

e9e902f7393ef4f4cb3f1cc69acde402c761c2d4
0fba21c1bfab48382acacd502e03d478a26a64b1
Comment 6 Jule Anger 2023-04-14 12:14:24 UTC 
Closing out bug report.

Thanks!
Comment 7 Samba QA Contact 2023-04-19 10:24:12 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.2):

330958ae80495311ae1718bfe021c05ecec77e05
dea4cb70045503fe882c2d4d24bfc07ce502c673
Comment 8 Samba QA Contact 2023-05-11 07:11:20 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.8):

e9e902f7393ef4f4cb3f1cc69acde402c761c2d4
0fba21c1bfab48382acacd502e03d478a26a64b1