Bug 15317 - winbindd idmap child contacts the domain controller without a need
Summary: winbindd idmap child contacts the domain controller without a need
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.18.0rc3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/-...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-23 06:54 UTC by Stefan Metzmacher
Modified: 2023-05-11 07:10 UTC (History)
1 user (show)

See Also:

Attachments
git-am fix for 4.18.next, 4.17.next (1.47 KB, patch)
2023-03-11 00:24 UTC, Jeremy Allison 		metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2023-02-23 06:54:21 UTC 
Most idmap backends don't need access to the domain controllers.
And the related code is not needed for the backends.
    
Commit 17c86a2c5a5a5e2b194362e5f36f0f99910222c5 changed
the logic of set_domain_online_request() completely!
Instead of triggering a dc probe in the background,
it is now doing a blocking connection.
And doing this in the idmap child is completely useless.
Comment 1 Samba QA Contact 2023-03-10 11:36:03 UTC 
This bug was referenced in samba master:

ad242a20643c930eb00a8b700f7bd9638f8821a8
Comment 2 Jeremy Allison 2023-03-11 00:24:12 UTC 
Created attachment 17801 [details]
git-am fix for 4.18.next, 4.17.next

Cherry-picked from master.
Comment 3 Jule Anger 2023-03-29 18:59:53 UTC 
Pushed to autobuild-v4-{18,17}-test.
Comment 4 Samba QA Contact 2023-03-30 16:11:23 UTC 
This bug was referenced in samba v4-17-test:

148d5ad7698d154731dfa092b0c6314c71f38086
Comment 5 Samba QA Contact 2023-04-05 11:42:12 UTC 
This bug was referenced in samba v4-18-test:

5c68985b2788330026df687d5439f4e86f90a77c
Comment 6 Jule Anger 2023-04-05 11:53:45 UTC 
Closing out bug report.

Thanks!
Comment 7 Samba QA Contact 2023-04-19 10:23:24 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.2):

5c68985b2788330026df687d5439f4e86f90a77c
Comment 8 Samba QA Contact 2023-05-11 07:10:23 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.8):

148d5ad7698d154731dfa092b0c6314c71f38086