Bug 15105 - Crash in streams_xattr because fsp->base_fsp->fsp_name is NULL
Summary: Crash in streams_xattr because fsp->base_fsp->fsp_name is NULL
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-22 08:33 UTC by Ralph Böhme
Modified: 2022-09-28 15:40 UTC (History)
2 users (show)

See Also:

Attachments
Patch for 4.15 and 4.16 cherry-picked from master (1.29 KB, patch)
2022-06-22 08:35 UTC, Ralph Böhme 		slow: review? (metze)
jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2022-06-22 08:33:24 UTC 
This is already fixed in master by 280e9191cbf8a766e69ab138450f2beccbedd879.

This can happen in the error codepath in non_widelink_open().

Got a customer report with a crash caused by this, so we need to backport 280e9191cbf8a766e69ab138450f2beccbedd879.
Comment 1 Ralph Böhme 2022-06-22 08:35:57 UTC 
Created attachment 17387 [details]
Patch for 4.15 and 4.16 cherry-picked from master
Comment 2 Jeremy Allison 2022-06-28 19:40:56 UTC 
Ping, can we get this one in please ? Flag me to review if needed :-).
Comment 3 Jeremy Allison 2022-06-28 20:47:43 UTC 
Re-assigning to Jule for inclusion in 4.16.next, 4.15.next.
Comment 4 Jule Anger 2022-07-11 10:22:57 UTC 
Pushed to autobuild-v4-{16,15}-test.
Comment 5 Samba QA Contact 2022-07-11 11:34:19 UTC 
This bug was referenced in samba v4-16-test:

54ad51cd3cc87bc77789821592b50aa1c3d0133c
Comment 6 Samba QA Contact 2022-07-12 14:45:12 UTC 
This bug was referenced in samba v4-15-test:

b70ea7082d69938a26183e5fbd9d6be524136336
Comment 7 Jule Anger 2022-07-12 15:26:30 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2022-07-18 11:18:58 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.3):

54ad51cd3cc87bc77789821592b50aa1c3d0133c
Comment 9 Samba QA Contact 2022-09-28 15:40:51 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.10):

b70ea7082d69938a26183e5fbd9d6be524136336