Bug 15013 - vfs_fruit: Unable to create folder icons
Summary: vfs_fruit: Unable to create folder icons
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.20.2
Hardware: x64 Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-11 13:31 UTC by Perttu Aaltonen
Modified: 2024-07-11 09:54 UTC (History)
1 user (show)

See Also:


Attachments
4.14.12 client log (8.54 MB, text/plain)
2022-03-11 13:31 UTC, Perttu Aaltonen
no flags Details
4.14.5 client log (29.01 MB, text/plain)
2022-03-11 13:32 UTC, Perttu Aaltonen
no flags Details
4.20.2 client log (11.36 MB, text/plain)
2024-07-10 09:18 UTC, Perttu Aaltonen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Perttu Aaltonen 2022-03-11 13:31:03 UTC
Created attachment 17208 [details]
4.14.12 client log

If both of these options are set:

fruit:encoding = native
fruit:delete_empty_adfiles = yes

...then pasting folder icons in the macOS Finder won't work.

When fruit:resource = file, two files are created inside the folder:

'._Icon'$'\r'
'Icon'$'\r'

On Samba 4.14.12 the '._Icon'$'\r' is not seen on the server, assumed to be immediately removed after creation.

On Samba 4.15.15 the '._Icon'$'\r' file is there but the folder icon doesn't appear. Folder in question can't be deleted from the client side because of a file-in-use error.

Switching to fruit:encoding = private restores functionality and icon creation works again.

Attached are two log files from 4.14.12 and 4.15.5 showing the following procedure:
1. Share opened
2. folder created
3. Standard macOS folder icon pasted to the created folder
4. Try to delete the created folder (only 4.15.5)
5. Share disconnected
Comment 1 Perttu Aaltonen 2022-03-11 13:32:27 UTC
Created attachment 17209 [details]
4.14.5 client log
Comment 2 Perttu Aaltonen 2024-07-10 09:18:37 UTC
Created attachment 18371 [details]
4.20.2 client log
Comment 3 Perttu Aaltonen 2024-07-10 09:41:02 UTC
Seems like the issue has gotten worse in recent versions. In 4.20.2 I can't get folder icons working with any combination of settings. Looks like the icon file is always truncated to 82 bytes.
Comment 4 Perttu Aaltonen 2024-07-10 09:42:13 UTC
Seems like the issue has gotten worse in recent versions. In 4.20.2 I can't get folder icons working with any combination of settings. Looks like the icon file is always truncated to 82 bytes.

I've added a fresh client log from 4.20.2. The share is opened, folder created and an icon pasted to the folder.
Comment 5 Perttu Aaltonen 2024-07-11 09:54:43 UTC
Copying a folder with an icon works, but not pasting an icon to existing folder.