Bug 14826 - ctdb doesn't ignore comments in the public_addresses file
Summary: ctdb doesn't ignore comments in the public_addresses file
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: CTDB (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-08 14:56 UTC by Ralph Böhme
Modified: 2021-10-27 13:22 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-15-test, v4-14-test (3.77 KB, patch)
2021-10-13 00:20 UTC, Martin Schwenke 		slow: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2021-09-08 14:56:38 UTC 
$ cat /etc/ctdb/public_addresses
# test
192.168.1.1/24 eth1
192.168.1.2/24 eth1

The script events/legacy/10.interface.script fails with

ctdb-eventd[210]: 10.interface: ERROR: Monitored interface test does not exist
ctdb-eventd[210]: monitor event failed

Have patch, need bugnumber.
Comment 1 Samba QA Contact 2021-10-12 23:25:03 UTC 
This bug was referenced in samba master:

530e8d4b9e47601b88e20bcaefa2d502efcebe60
5426c104f5090751c1ea02f0c0667d8d071a4a83
4e3676cb3c4d24cd4c287703d2cd812a2a8c36ff
Comment 2 Martin Schwenke 2021-10-13 00:20:50 UTC 
Created attachment 16849 [details]
Patch for v4-15-test, v4-14-test

Cherry-picked cleanly from master in v4-15-test.  Patch created from there applies cleanly to v4-14-test.  Passes relevant (updated) unit tests in both branches.
Comment 3 Ralph Böhme 2021-10-13 17:22:38 UTC 
Comment on attachment 16849 [details]
Patch for v4-15-test, v4-14-test

Thanks for the fixes!
Comment 4 Ralph Böhme 2021-10-13 17:23:03 UTC 
Reassigning to Jule for inclusion in 4.14 and 4.15.
Comment 5 Jule Anger 2021-10-18 07:23:48 UTC 
Pushed to autobuild-v4-{15,14}-test.
Comment 6 Samba QA Contact 2021-10-18 08:42:07 UTC 
This bug was referenced in samba v4-14-test:

a200f88452e6daac6ece9738ab3192470224aac9
c10d2880356ded48bc7aac1e4540acdc092d34dc
44636fa037814fe71d2397865ff3cfa88f8fd35c
Comment 7 Samba QA Contact 2021-10-18 09:25:15 UTC 
This bug was referenced in samba v4-15-test:

36621069e261ed521b4b61495c14b949f543e2cc
63a3b7838e19dd414580df91f11b40a5cd065cbc
d3df31162f0a36b7c813b5ffce158586536c1aa4
Comment 8 Jule Anger 2021-10-18 09:30:09 UTC 
Closing out bug report.

Thanks!
Comment 9 Samba QA Contact 2021-10-27 13:11:59 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.1):

36621069e261ed521b4b61495c14b949f543e2cc
63a3b7838e19dd414580df91f11b40a5cd065cbc
d3df31162f0a36b7c813b5ffce158586536c1aa4
Comment 10 Samba QA Contact 2021-10-27 13:22:40 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.9):

a200f88452e6daac6ece9738ab3192470224aac9
c10d2880356ded48bc7aac1e4540acdc092d34dc
44636fa037814fe71d2397865ff3cfa88f8fd35c