Bug 14786 - Insufficient libreplace check for SYS_copy_file_range check
Summary: Insufficient libreplace check for SYS_copy_file_range check
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-06 14:31 UTC by Ralph Böhme
Modified: 2023-07-21 13:28 UTC (History)
1 user (show)

See Also:

Attachments
Patch for 4.15 cherry-picked from master (4.39 KB, patch)
2021-08-11 15:37 UTC, Ralph Böhme 		metze: review-
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2021-08-06 14:31:45 UTC 
It seems some systems like Centos 7 have the SYS_copy_file_range define but fail the syscall when actually being called.

The current configure check only compiles the testcode, but it doesn't run it, so this is not detected properly.
Comment 1 Samba QA Contact 2021-08-10 19:38:03 UTC 
This bug was referenced in samba master:

22a58a51846749495613e5b572c31ba4752bc61b
4354823c5146753ef8a3791bc8562379096659b8
Comment 2 Ralph Böhme 2021-08-11 15:37:58 UTC 
Created attachment 16728 [details]
Patch for 4.15 cherry-picked from master

Patched code is in only in 4.15, so no need for backports to older versions.
Comment 3 Stefan Metzmacher 2021-08-26 12:52:58 UTC 
Comment on attachment 16728 [details]
Patch for 4.15 cherry-picked from master

The 2nd patch is actually wrong, we should not do a runtime check at configure time. We should actually revert that one in master. And the first commit is only
cosmetic and is not needed in 4.15.
Comment 4 Stefan Metzmacher 2021-08-26 12:54:42 UTC 
(In reply to Stefan Metzmacher from comment #3)

https://bugzilla.samba.org/show_bug.cgi?id=14795 actually implemented a real runtime check.
Comment 5 Ralph Böhme 2021-09-05 13:14:07 UTC 
(In reply to Stefan Metzmacher from comment #3)
https://gitlab.com/samba-team/samba/-/merge_requests/2153