Created attachment 16706 [details]
possible patch to include type into some 3 argument *acl_sys_set_fd() refs

In the stable release 4.14.6 the prototype for solarisacl_sys_acl_set_fd() in s3/modules/vfs_solarisacl.h is listed with 3 arguments, while the code in s3/modules/vfs_solarisacl.c has 4.  This leads to a compile error.  The latter reflects the upcoming release, with code in solarisacl_sys_acl_set_fd() checking for the type.

The commit was "vfs: add acl type arg to SMB_VFS_SYS_ACL_SET_FD()" that made the partial change.  Later commits which updated the header files and other files may be desired since much code is touched.  Or not since this branch is meant to be stable.  If the later, a patch mimicking what was done with posixacl_sys_acl_set_fd() is attached.

solarisacl_sys_acl_set_fd() is only called from sys_acl_set_fd() in s3/lib/sysacls.c which in turn is only called by vfswrap_sys_acl_set_fd() in s3/modules/vfs_default.c when type == SMB_ACL_TYPE_ACCESS.  The proposed patch mimics the call to posixacl_sys_acl_set_fd() by setting the type argument to SMB_ACL_TYPE_ACCESS.

More OS's, like tru64 and aix, are also affected and are updated the same way to resolve compile errors. The patch updates s3/lib/sysacls.c and the header files (except for aix, which doesn't seem to exist? but is also 4 args in vfs_aixacl.c but 3 in s3/lib/sysacls.c).  hpux uses 3 arguments everywhere and that is not changed here.

The upcoming release is not affected, only the 4.14 line.